Seems quite good to me, last notes: 1) dealing with 'stat/stat64' in 'UnixFileSystem_md.c' might be outside the scope of this fix (?) even if fully pertinent per [1]. In the same file, I think '#define dirent dirent64' is probably missing for AIX. 2) I guess '#if defined(_AIX) ...' is now missing in 'OperatingSystemImpl.c': #if defined(_AIX) #define DIR DIR64 #define dirent dirent64 #define opendir opendir64 #define readdir readdir64 #define closedir closedir64 #endif You'll probably need some more reviews especially for other systems than Linux 64-bit. Thanks, Bernard [1] https://www.gnu.org/software/libc/manual/html_node/Reading-Attributes.html On 13 August 2018 at 23:26, Brian Burkhalter <brian.burkhalter@oracle.com> wrote:
Hi Bernard,
I updated the patch per your suggestions and it checks out on our systems.
http://cr.openjdk.java.net/~bpb/8207744/webrev.04/
Thanks,
Brian
On Aug 10, 2018, at 6:20 AM, B. Blaser <bsrbnd@gmail.com> wrote:
Among the files you suggest to fix, only the following ones are still using 'readdir64' for other systems than AIX: