Looks good to me.
-----Original Message----- From: Baesken, Matthias Sent: Mittwoch, 12. September 2018 11:27 To: Sean Mullan <sean.mullan@oracle.com>; Langer, Christoph <christoph.langer@sap.com>; Weijun Wang <weijun.wang@oracle.com> Cc: security-dev@openjdk.java.net; core-libs-dev@openjdk.java.net Subject: RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives
Hello I changed it to jar , also added some minor adjustments suggested by Christoph .
http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.12/
Regards, Matthias
-----Original Message----- From: Sean Mullan <sean.mullan@oracle.com> Sent: Dienstag, 11. September 2018 20:44 To: Langer, Christoph <christoph.langer@sap.com>; Baesken, Matthias <matthias.baesken@sap.com>; Weijun Wang <weijun.wang@oracle.com> Cc: security-dev@openjdk.java.net; core-libs-dev@openjdk.java.net Subject: Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives
On 9/11/18 8:14 AM, Langer, Christoph wrote:
Hi,
first of all, I suggest to use "jarDetails" instead of "jarPath" as category name. Because with this contribution we add the notion of jar file plus line of manifest to Exceptions occurring when parsing jar manifests. And if there were further Exception details to be added in the area of jar files, they could go under a category "jarDetails" as well. Would you agree? Then, in Manifest.java, the field "jarPathInExceptionText" could be renamed to "detailedExceptions".
Or just "jar" would be my preference. I don't like "jarPath" as that sounds too much like a file pathname to me, which we have now removed.
--Sean