Hi Sean, Max, do you think we need property jdk.includeInExceptions=jar<File/Path> at all, if we don't resolve the absolute path? @Matthias: small remark to the code: src/java.base/share/classes/sun/security/util/SecurityProperties.java 36 public static String privilegeGetOverridable(String propName) { Should that method really be public? At the moment it doesn't seem to be used outside of SecurityProperties. Best regards Christoph
-----Original Message----- From: Weijun Wang <weijun.wang@oracle.com> Sent: Montag, 10. September 2018 16:43 To: Sean Mullan <sean.mullan@oracle.com> Cc: Baesken, Matthias <matthias.baesken@sap.com>; Langer, Christoph <christoph.langer@sap.com>; security-dev@openjdk.java.net; core-libs- dev@openjdk.java.net Subject: Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives
On Sep 10, 2018, at 10:35 PM, Sean Mullan <sean.mullan@oracle.com> wrote:
After the changes I wonder - should the jarPath category be renamed to jarFile (or something else) ?
Yes, renaming it to "jarFile" makes more sense. You will need to update the CSR with this change too.
Well, maybe either is OK.
I am still thinking that one day we could make this more precise, for example:
/path/to/lib.jar!META-INF/MANIFEST.MF:23 /path/to/lib.jar!META-INF/SIGNER.SF:34
The name should (at least vaguely) cover these info.
--Max