13 May
2020
13 May
'20
1:59 p.m.
On 13 May 2020, at 13:12, Maurizio Cimadamore <maurizio.cimadamore@oracle.com> wrote:
Another iteration which addresses the latest CSR comments (the CSR has now been approved):
* make MemorySegment::withAccessModes/hasAccessMode throw IllegalArgumentException in cases where the provided mask is invalid (this required a test tweak) * sprinkled a couple of references to the JLS in the package javadoc, as per CSR suggestions * Fixed the ParallelSum::findAny_bulk benchmarks, which were (erroneously) not testing all the elements in the segment
Webrev:
http://cr.openjdk.java.net/~mcimadamore/8243491_v4/webrev
Delta webrev:
http://cr.openjdk.java.net/~mcimadamore/8243491_v4/webrev_delta/
This latest version looks good to me. Reviewed. -Chris.