Hi Alan/Sundar, Please review the revised webrev with copyright header change at http://cr.openjdk.java.net/~sdama/8011697/webrev.02/ Regards, srinivas -----Original Message----- From: Sundararajan Athijegannathan Sent: Tuesday, January 30, 2018 8:53 PM To: core-libs-dev@openjdk.java.net Subject: Re: RFR: 8011697(ScriptEngine "js" randomly means either "rhino" or "nashorn", but should instead select one) +1 (with the copyright header change suggested by Alan) -Sundar On 30/01/18, 8:28 PM, Alan Bateman wrote:
On 30/01/2018 09:17, Srinivas Dama wrote:
Hi,
Please review the revised webrev at http://cr.openjdk.java.net/~sdama/8011697/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8011697
The updated patch to ScriptEngineManager looks okay.
Can you replace the copyright header in the tests with the GPL version before you push this? We don't use the GPL + "Classpath" exception header in tests.
-Alan