On Wed, 7 Jul 2021 16:22:25 GMT, Mandy Chung <mchung@openjdk.org> wrote:
Hi Mandy, thanks for reviewing this.
I suggest to separate the client changes (both src and test) in a separate PR for the client review.
Does "client changes" means changes involving src/java.desktop and test/java/awt?
src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java needs to be updated in JSR 166 upstream repo. Better to file a separate issue for this change to ensure that gets fixed in the upstream project.
Can you please paste a link for that? I'm not sure where I can find JSR 166 upstream repo..
Nit: The above formatting (line 70-97) is inconsistent with the formatting in line 110-124. It'd be good to use the same formatting.
Restored.
Does "client changes" means changes involving src/java.desktop and test/java/awt?
src/java.desktop, test/java/awt, and test/javax/imageio
src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java needs to be updated in JSR 166 upstream repo. Better to file a separate issue for this change to ensure that gets fixed in the upstream project.
Can you please paste a link for that? I'm not sure where I can find JSR 166 upstream repo..
What I meant is to file a JBS issue for this change and revert the change in this patch. That can be fixed when the next JSR 166 changes are imported to JDK. I wasn't sure if this is the right repo: http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/ ------------- PR: https://git.openjdk.java.net/jdk/pull/4507