RFR: 8378874: jpackage: remove redundant messages
On macOS, remove message.signing.pkg=Warning: For signing PKG, you might need to set "Always Trust" for your certificate using "Keychain Access" tool. This warning is redundant, as the user should have this type of configuration when using jpackage for any signing. On Windows, remove message.use-wix36-features=WiX {0} detected. Enabling advanced cleanup action. This notification is redundant: The oldest officially available version of WiX is 3.11. ------------- Commit messages: - Update copyright year - Remove "message.signing.pkg" warning - Remove redundant "message.use-wix36-features" info message Changes: https://git.openjdk.org/jdk/pull/29907/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29907&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8378874 Stats: 31 lines in 6 files changed: 1 ins; 28 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/29907.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29907/head:pull/29907 PR: https://git.openjdk.org/jdk/pull/29907
On Wed, 25 Feb 2026 02:11:51 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
On macOS, remove
message.signing.pkg=Warning: For signing PKG, you might need to set "Always Trust" for your certificate using "Keychain Access" tool.
This warning is redundant, as the user should have this type of configuration when using jpackage for any signing.
On Windows, remove
message.use-wix36-features=WiX {0} detected. Enabling advanced cleanup action.
This notification is redundant: The oldest officially available version of WiX is 3.11.
@sashamatveev PTAL ------------- PR Comment: https://git.openjdk.org/jdk/pull/29907#issuecomment-3975186260
On Wed, 25 Feb 2026 02:11:51 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
On macOS, remove
message.signing.pkg=Warning: For signing PKG, you might need to set "Always Trust" for your certificate using "Keychain Access" tool.
This warning is redundant, as the user should have this type of configuration when using jpackage for any signing.
On Windows, remove
message.use-wix36-features=WiX {0} detected. Enabling advanced cleanup action.
This notification is redundant: The oldest officially available version of WiX is 3.11.
Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29907#pullrequestreview-3879718009
On Wed, 25 Feb 2026 02:11:51 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
On macOS, remove
message.signing.pkg=Warning: For signing PKG, you might need to set "Always Trust" for your certificate using "Keychain Access" tool.
This warning is redundant, as the user should have this type of configuration when using jpackage for any signing.
On Windows, remove
message.use-wix36-features=WiX {0} detected. Enabling advanced cleanup action.
This notification is redundant: The oldest officially available version of WiX is 3.11.
This pull request has now been integrated. Changeset: 73363a0c Author: Alexey Semenyuk <asemenyuk@openjdk.org> URL: https://git.openjdk.org/jdk/commit/73363a0cb501eb10f5be4a6a283b20da58b1950d Stats: 31 lines in 6 files changed: 1 ins; 28 del; 2 mod 8378874: jpackage: remove redundant messages Reviewed-by: almatvee ------------- PR: https://git.openjdk.org/jdk/pull/29907
participants (2)
-
Alexander Matveev
-
Alexey Semenyuk