[10]RFR 8190278: ClassCastException is thrown by java.util.Scanner when a NumberFormatProvider is used.
Hi, Please review the fix for JDK-8190278 Bug: https://bugs.openjdk.java.net/browse/JDK-8190278 Webrev: http://cr.openjdk.java.net/~nishjain/8190278/webrev.03/ Fix: Modified the code to check whether the object returned by NumberFormat#getNumberInstance(Locale) is a DecimalFormat object, if not, then use the DecimalFormat constructor way to create its object, where SPI provider implementation is ignored. Regards, Nishit Jain
Looks good to me. Naoto On 12/11/17 1:04 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8190278
Bug: https://bugs.openjdk.java.net/browse/JDK-8190278 Webrev: http://cr.openjdk.java.net/~nishjain/8190278/webrev.03/
Fix: Modified the code to check whether the object returned by NumberFormat#getNumberInstance(Locale) is a DecimalFormat object, if not, then use the DecimalFormat constructor way to create its object, where SPI provider implementation is ignored.
Regards, Nishit Jain
Hi Nishit, Looks fine to me Regards, Roger On 12/11/2017 4:01 PM, Naoto Sato wrote:
Looks good to me.
Naoto
On 12/11/17 1:04 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8190278
Bug: https://bugs.openjdk.java.net/browse/JDK-8190278 Webrev: http://cr.openjdk.java.net/~nishjain/8190278/webrev.03/
Fix: Modified the code to check whether the object returned by NumberFormat#getNumberInstance(Locale) is a DecimalFormat object, if not, then use the DecimalFormat constructor way to create its object, where SPI provider implementation is ignored.
Regards, Nishit Jain
participants (3)
-
Naoto Sato
-
Nishit Jain
-
Roger Riggs