RFR: 8378867: jpackage references non-existing "message.app-image-requires-identifier" l10n key
Fix missing l10n key. Add a test to cover the fix. ------------- Commit messages: - MacApplicationBuilder: fix missing "message.app-image-requires-identifier" key Changes: https://git.openjdk.org/jdk/pull/29905/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29905&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8378867 Stats: 40 lines in 4 files changed: 34 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/29905.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29905/head:pull/29905 PR: https://git.openjdk.org/jdk/pull/29905
On Wed, 25 Feb 2026 02:03:57 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Fix missing l10n key. Add a test to cover the fix.
@sashamatveev PTAL ------------- PR Comment: https://git.openjdk.org/jdk/pull/29905#issuecomment-3975395181
On Wed, 25 Feb 2026 02:03:57 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Fix missing l10n key. Add a test to cover the fix.
Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29905#pullrequestreview-3879321631
On Wed, 25 Feb 2026 02:03:57 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Fix missing l10n key. Add a test to cover the fix.
Marked as reviewed by almatvee (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29905#pullrequestreview-3880065317
On Wed, 25 Feb 2026 02:03:57 GMT, Alexey Semenyuk <asemenyuk@openjdk.org> wrote:
Fix missing l10n key. Add a test to cover the fix.
This pull request has now been integrated. Changeset: 297812ee Author: Alexey Semenyuk <asemenyuk@openjdk.org> URL: https://git.openjdk.org/jdk/commit/297812eec1ad5c9f48822ace2bd720fd02c6b263 Stats: 40 lines in 4 files changed: 34 ins; 3 del; 3 mod 8378867: jpackage references non-existing "message.app-image-requires-identifier" l10n key Reviewed-by: almatvee ------------- PR: https://git.openjdk.org/jdk/pull/29905
participants (2)
-
Alexander Matveev
-
Alexey Semenyuk