RFR(S) 8241815: Unnecessary calls to SystemDictionaryShared::define_shared_package
JBS: https://bugs.openjdk.java.net/browse/JDK-8241815 webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8241815/webrev.00/ This change is to avoid java up call of definePackage() while loading a shared app/platform class originated from the module image since the packages from module image are already created during VM bootstrap in Module::define_module(). (including core-libs-dev since the change removes two methods in jdk/internal/loader/ClassLoaders.java) Testing: tier1 - 4. thanks, Calvin
On 4/27/20 12:21 PM, Calvin Cheung wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8241815 webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8241815/webrev.00/
This change is to avoid java up call of definePackage() while loading a shared app/platform class originated from the module image since the packages from module image are already created during VM bootstrap in Module::define_module().
(including core-libs-dev since the change removes two methods in jdk/internal/loader/ClassLoaders.java)
java.lang.Package for named modules are automatically defined and this patch looks okay to me. Mandy
Hi Mandy, Thanks for your review! Calvin On 4/27/20 2:39 PM, Mandy Chung wrote:
On 4/27/20 12:21 PM, Calvin Cheung wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8241815 webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8241815/webrev.00/
This change is to avoid java up call of definePackage() while loading a shared app/platform class originated from the module image since the packages from module image are already created during VM bootstrap in Module::define_module().
(including core-libs-dev since the change removes two methods in jdk/internal/loader/ClassLoaders.java)
java.lang.Package for named modules are automatically defined and this patch looks okay to me.
Mandy
Looks good Calvin. Lois On 4/27/2020 3:21 PM, Calvin Cheung wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8241815 webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8241815/webrev.00/
This change is to avoid java up call of definePackage() while loading a shared app/platform class originated from the module image since the packages from module image are already created during VM bootstrap in Module::define_module().
(including core-libs-dev since the change removes two methods in jdk/internal/loader/ClassLoaders.java)
Testing: tier1 - 4.
thanks,
Calvin
Hi Lois, Thanks for your review! Calvin On 4/27/20 3:22 PM, Lois Foltan wrote:
Looks good Calvin. Lois
On 4/27/2020 3:21 PM, Calvin Cheung wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8241815 webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8241815/webrev.00/
This change is to avoid java up call of definePackage() while loading a shared app/platform class originated from the module image since the packages from module image are already created during VM bootstrap in Module::define_module().
(including core-libs-dev since the change removes two methods in jdk/internal/loader/ClassLoaders.java)
Testing: tier1 - 4.
thanks,
Calvin
Hi Calvin, this looks good to me, too. Thanks - Ioi On 4/27/20 12:21 PM, Calvin Cheung wrote:
JBS: https://bugs.openjdk.java.net/browse/JDK-8241815 webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8241815/webrev.00/
This change is to avoid java up call of definePackage() while loading a shared app/platform class originated from the module image since the packages from module image are already created during VM bootstrap in Module::define_module().
(including core-libs-dev since the change removes two methods in jdk/internal/loader/ClassLoaders.java)
Testing: tier1 - 4.
thanks,
Calvin
participants (4)
-
Calvin Cheung
-
Ioi Lam
-
Lois Foltan
-
Mandy Chung