RFR: 8253866: Security Libs Terminology Refresh
This is the security libs portion of the effort to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details). Here are the changes covering core libraries code and tests. Terms were changed as follows: - blacklisted.certs -> blocked.certs (along with supporting make infrastructure and tests) - master/slave in KRB5 -> primary/replica - blacklist in other files -> deny list - whitelist -> allow list Addressing similar issues in upstream 3rd party code is out of scope of this PR. Such changes will be picked up from their upstream sources. ------------- Commit messages: - Merge main branch - 8253866: Security Libs Terminology Refresh Changes: https://git.openjdk.java.net/jdk/pull/2074/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2074&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253866 Stats: 351 lines in 17 files changed: 152 ins; 150 del; 49 mod Patch: https://git.openjdk.java.net/jdk/pull/2074.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2074/head:pull/2074 PR: https://git.openjdk.java.net/jdk/pull/2074
On Thu, 14 Jan 2021 06:32:37 GMT, Jamil Nimeh <jnimeh@openjdk.org> wrote:
This is the security libs portion of the effort to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
Here are the changes covering core libraries code and tests. Terms were changed as follows:
- blacklisted.certs -> blocked.certs (along with supporting make infrastructure and tests) - master/slave in KRB5 -> primary/replica - blacklist in other files -> deny list - whitelist -> allow list
Addressing similar issues in upstream 3rd party code is out of scope of this PR. Such changes will be picked up from their upstream sources.
Build changes look good. ------------- Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2074
On Thu, 14 Jan 2021 06:32:37 GMT, Jamil Nimeh <jnimeh@openjdk.org> wrote:
This is the security libs portion of the effort to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
Here are the changes covering core libraries code and tests. Terms were changed as follows:
- blacklisted.certs -> blocked.certs (along with supporting make infrastructure and tests) - master/slave in KRB5 -> primary/replica - blacklist in other files -> deny list - whitelist -> allow list
Addressing similar issues in upstream 3rd party code is out of scope of this PR. Such changes will be picked up from their upstream sources.
Code change looks fine to me. ------------- Marked as reviewed by weijun (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2074
On Thu, 14 Jan 2021 06:32:37 GMT, Jamil Nimeh <jnimeh@openjdk.org> wrote:
This is the security libs portion of the effort to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
Here are the changes covering core libraries code and tests. Terms were changed as follows:
- blacklisted.certs -> blocked.certs (along with supporting make infrastructure and tests) - master/slave in KRB5 -> primary/replica - blacklist in other files -> deny list - whitelist -> allow list
Addressing similar issues in upstream 3rd party code is out of scope of this PR. Such changes will be picked up from their upstream sources.
Marked as reviewed by mullan (Reviewer). src/java.base/share/conf/security/java.security line 454:
452: # configuration, but with smaller max_retries and timeout values. 453: # max_retries and timeout are optional numerical parameters (default 1 and 454: # 5000, which means once and 5 seconds). Please notes that if any of the
Typo: s/notes/note/ src/java.base/share/conf/security/java.security line 455:
453: # max_retries and timeout are optional numerical parameters (default 1 and 454: # 5000, which means once and 5 seconds). Please notes that if any of the 455: # values defined here is more than what is defined in krb5.conf, it will be
Typo: s/is more/are more/ ------------- PR: https://git.openjdk.java.net/jdk/pull/2074
On Thu, 14 Jan 2021 15:45:43 GMT, Sean Mullan <mullan@openjdk.org> wrote:
Jamil Nimeh has updated the pull request incrementally with one additional commit since the last revision:
Minor grammatical fixes
src/java.base/share/conf/security/java.security line 455:
453: # max_retries and timeout are optional numerical parameters (default 1 and 454: # 5000, which means once and 5 seconds). Please notes that if any of the 455: # values defined here is more than what is defined in krb5.conf, it will be
Typo: s/is more/are more/
Done. Good catch.
src/java.base/share/conf/security/java.security line 454:
452: # configuration, but with smaller max_retries and timeout values. 453: # max_retries and timeout are optional numerical parameters (default 1 and 454: # 5000, which means once and 5 seconds). Please notes that if any of the
Typo: s/notes/note/
fixed ------------- PR: https://git.openjdk.java.net/jdk/pull/2074
This is the security libs portion of the effort to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
Here are the changes covering core libraries code and tests. Terms were changed as follows:
- blacklisted.certs -> blocked.certs (along with supporting make infrastructure and tests) - master/slave in KRB5 -> primary/replica - blacklist in other files -> deny list - whitelist -> allow list
Addressing similar issues in upstream 3rd party code is out of scope of this PR. Such changes will be picked up from their upstream sources.
Jamil Nimeh has updated the pull request incrementally with one additional commit since the last revision: Minor grammatical fixes ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2074/files - new: https://git.openjdk.java.net/jdk/pull/2074/files/9d44a9e1..45492f55 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2074&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2074&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2074.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2074/head:pull/2074 PR: https://git.openjdk.java.net/jdk/pull/2074
On Thu, 14 Jan 2021 06:32:37 GMT, Jamil Nimeh <jnimeh@openjdk.org> wrote:
This is the security libs portion of the effort to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details).
Here are the changes covering core libraries code and tests. Terms were changed as follows:
- blacklisted.certs -> blocked.certs (along with supporting make infrastructure and tests) - master/slave in KRB5 -> primary/replica - blacklist in other files -> deny list - whitelist -> allow list
Addressing similar issues in upstream 3rd party code is out of scope of this PR. Such changes will be picked up from their upstream sources.
This pull request has now been integrated. Changeset: 8554fe6e Author: Jamil Nimeh <jnimeh@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/8554fe6e Stats: 351 lines in 17 files changed: 152 ins; 150 del; 49 mod 8253866: Security Libs Terminology Refresh Reviewed-by: erikj, weijun, mullan ------------- PR: https://git.openjdk.java.net/jdk/pull/2074
participants (4)
-
Erik Joelsson
-
Jamil Nimeh
-
Sean Mullan
-
Weijun Wang