RFR: 8262807: Note assumptions of core reflection modeling and parameter handling
Please review the javadoc change below, written in response to recent discussion on core-libs. The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups. I'll update copyright, etc. after agreement on the text is reached. ------------- Commit messages: - Appease jcheck. - 8262807: Note assumptions of core reflection modeling and parameter handling Changes: https://git.openjdk.java.net/jdk/pull/3036/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3036&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262807 Stats: 90 lines in 4 files changed: 69 ins; 6 del; 15 mod Patch: https://git.openjdk.java.net/jdk/pull/3036.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3036/head:pull/3036 PR: https://git.openjdk.java.net/jdk/pull/3036
On Tue, 16 Mar 2021 17:22:13 GMT, Joe Darcy <darcy@openjdk.org> wrote:
Please review the javadoc change below, written in response to recent discussion on core-libs.
The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups.
I'll update copyright, etc. after agreement on the text is reached.
src/java.base/share/classes/java/lang/reflect/package-info.java line 79:
77: * differ from the modifiers on the originating element in the source 78: * language, including {@link Modifier#FINAL final} on a {@linkplain 79: * Parameter#getModifiers() parameter} and and {@code protected},
and and -> "and" src/java.base/share/classes/java/lang/reflect/package-info.java line 85:
83: * <p>Besides differences in structural representation between the 84: * source language and the JVM representation, core reflection also 85: * exposed runtime specific information. For example, the {@linkplain
exposed -> exposes src/java.base/share/classes/java/lang/reflect/Executable.java line 262:
260: * Returns an array of {@code Type} objects that represent the 261: * formal parameter types, in declaration order, of the executable 262: * represented by this object. Returns an array of length 0 if the
Missing subject of the sentence? "This method returns"... Or "An array of length 0 is returned"... ------------- PR: https://git.openjdk.java.net/jdk/pull/3036
Please review the javadoc change below, written in response to recent discussion on core-libs.
The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups.
I'll update copyright, etc. after agreement on the text is reached.
Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3036/files - new: https://git.openjdk.java.net/jdk/pull/3036/files/74b2bd59..3f102171 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3036&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3036&range=00-01 Stats: 19 lines in 3 files changed: 0 ins; 9 del; 10 mod Patch: https://git.openjdk.java.net/jdk/pull/3036.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3036/head:pull/3036 PR: https://git.openjdk.java.net/jdk/pull/3036
On Tue, 16 Mar 2021 20:41:24 GMT, Joe Darcy <darcy@openjdk.org> wrote:
Please review the javadoc change below, written in response to recent discussion on core-libs.
The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups.
I'll update copyright, etc. after agreement on the text is reached.
Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
Respond to review feedback.
looks good. ------------- Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3036
Please review the javadoc change below, written in response to recent discussion on core-libs.
The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups.
I'll update copyright, etc. after agreement on the text is reached.
Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge and update copyright year. - Merge branch 'master' into 8262807 - Respond to review feedback. - Appease jcheck. - 8262807: Note assumptions of core reflection modeling and parameter handling ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3036/files - new: https://git.openjdk.java.net/jdk/pull/3036/files/3f102171..c2bf7434 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3036&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3036&range=01-02 Stats: 2708 lines in 204 files changed: 1275 ins; 709 del; 724 mod Patch: https://git.openjdk.java.net/jdk/pull/3036.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3036/head:pull/3036 PR: https://git.openjdk.java.net/jdk/pull/3036
Please review the javadoc change below, written in response to recent discussion on core-libs.
The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups.
I'll update copyright, etc. after agreement on the text is reached.
Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Per current terminology conventions, "types" -> "classes and interfaces" in package-info. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3036/files - new: https://git.openjdk.java.net/jdk/pull/3036/files/c2bf7434..cd6fd6fe Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3036&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3036&range=02-03 Stats: 18 lines in 1 file changed: 0 ins; 0 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/3036.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3036/head:pull/3036 PR: https://git.openjdk.java.net/jdk/pull/3036
On Tue, 16 Mar 2021 17:22:13 GMT, Joe Darcy <darcy@openjdk.org> wrote:
Please review the javadoc change below, written in response to recent discussion on core-libs.
The bulk of the change is to add a discussion to java.lang.reflect's package-info file about a language vs JVM model for core reflection. That discussion is then linked to from several relevant locations core reflection. A discussion of generic parameter handling is also added along with various small cleanups.
I'll update copyright, etc. after agreement on the text is reached.
This pull request has now been integrated. Changeset: 99b39aad Author: Joe Darcy <darcy@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/99b39aad Stats: 108 lines in 4 files changed: 69 ins; 15 del; 24 mod 8262807: Note assumptions of core reflection modeling and parameter handling Reviewed-by: rriggs ------------- PR: https://git.openjdk.java.net/jdk/pull/3036
participants (2)
-
Joe Darcy
-
Roger Riggs