[12] Review Request: 8205537 Drop of sun.applet package
Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8205537 Webrev: http://cr.openjdk.java.net/~serb/8205537/webrev.00/ sun.applet is an internal package contained some code related to implementation of applets and appletviewer. Some of its classes were dropped already: JDK-8204454, JDK-8203308. Now there are only 3 classes, all related to the applet security and we can drop them as well. In the fix this package was removed, and the tests were updated to not use it. I am not sure how "ClassnameCharTest.java" is useful after applets removal, but since this test used subclass of the AppletClassLoader, I have copied some code from the removed class to the test. -- Best regards, Sergey.
On 31/07/2018 16:39, Sergey Bylokhov wrote:
Hello. Please review the fix for jdk11.
typo, I meant jdk12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8205537 Webrev: http://cr.openjdk.java.net/~serb/8205537/webrev.00/
sun.applet is an internal package contained some code related to implementation of applets and appletviewer. Some of its classes were dropped already: JDK-8204454, JDK-8203308. Now there are only 3 classes, all related to the applet security and we can drop them as well.
In the fix this package was removed, and the tests were updated to not use it. I am not sure how "ClassnameCharTest.java" is useful after applets removal, but since this test used subclass of the AppletClassLoader, I have copied some code from the removed class to the test.
-- Best regards, Sergey.
- * @summary Checks that SwingLazyValue class correclty works + * @summary Checks that SwingLazyValue class correctly works And "correctly works" should be "works correctly" For test/jdk/sun/misc/URLClassPath/ClassnameCharTest.java please add a comment that the class loader code was copied from the now deleted AppletClassLoader. I don't need to see an updated webrev for those minor changes. -phil. On 7/31/2018 4:39 PM, Sergey Bylokhov wrote:
Hello. Please review the fix for jdk11.
Bug: https://bugs.openjdk.java.net/browse/JDK-8205537 Webrev: http://cr.openjdk.java.net/~serb/8205537/webrev.00/
sun.applet is an internal package contained some code related to implementation of applets and appletviewer. Some of its classes were dropped already: JDK-8204454, JDK-8203308. Now there are only 3 classes, all related to the applet security and we can drop them as well.
In the fix this package was removed, and the tests were updated to not use it. I am not sure how "ClassnameCharTest.java" is useful after applets removal, but since this test used subclass of the AppletClassLoader, I have copied some code from the removed class to the test.
participants (2)
-
Phil Race
-
Sergey Bylokhov