[PATCH] Review Request for bug 7132247 java/rmi/registry/readTest/readTest.sh failing with Cygwin
Hi Alan, Please help to review the below fix for** bug 7132247 <http://monaco.us.oracle.com/detail.jsf?cr=7132247> java/rmi/registry/readTest/readTest.sh failing with Cygwin. http://dl.dropbox.com/u/90659131/fixes/7132247/webrev/index.html Root cause of this bug is: 1. CYGWIN doesn't handle "\\" correctly, if say FS="\\"; echo $FS, in cgywin, will print \\\\ which cause file not found. 2. Java doesn't recognize CYGWIN style path like "/cygwin/d/...", should use cygpath to convert to Windows native path. Thanks, Eric
On 13/08/2012 10:30, Eric Wang wrote:
Hi Alan,
Please help to review the below fix for** bug 7132247 <http://monaco.us.oracle.com/detail.jsf?cr=7132247> java/rmi/registry/readTest/readTest.sh failing with Cygwin. http://dl.dropbox.com/u/90659131/fixes/7132247/webrev/index.html
Root cause of this bug is: 1. CYGWIN doesn't handle "\\" correctly, if say FS="\\"; echo $FS, in cgywin, will print \\\\ which cause file not found. 2. Java doesn't recognize CYGWIN style path like "/cygwin/d/...", should use cygpath to convert to Windows native path.
Thanks, Eric This looks good to me and good to have another test off the exclude list.
Stuart - are you going to sponsor this one? -Alan.
participants (2)
-
Alan Bateman
-
Eric Wang