RFR: 8267614: Outline VarHandleGuards exact behavior checks
Extract some common behavior checks from the generated VarHandleGuards code to a package-private VarHandle method. This reduces the code size (-5.2kb lib/modules) and slightly improves startup, while being performance neutral on microbenchmarks. ------------- Commit messages: - Outline VarHandleGuard exact behavior checks Changes: https://git.openjdk.java.net/jdk/pull/4165/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4165&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267614 Stats: 338 lines in 3 files changed: 14 ins; 243 del; 81 mod Patch: https://git.openjdk.java.net/jdk/pull/4165.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4165/head:pull/4165 PR: https://git.openjdk.java.net/jdk/pull/4165
On Mon, 24 May 2021 11:47:53 GMT, Claes Redestad <redestad@openjdk.org> wrote:
Extract some common behavior checks from the generated VarHandleGuards code to a package-private VarHandle method. This reduces the code size (-5.2kb lib/modules) and slightly improves startup, while being performance neutral on microbenchmarks.
Looks good. ------------- Marked as reviewed by psandoz (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4165
On Mon, 24 May 2021 11:47:53 GMT, Claes Redestad <redestad@openjdk.org> wrote:
Extract some common behavior checks from the generated VarHandleGuards code to a package-private VarHandle method. This reduces the code size (-5.2kb lib/modules) and slightly improves startup, while being performance neutral on microbenchmarks.
Marked as reviewed by mchung (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/4165
On Mon, 24 May 2021 11:47:53 GMT, Claes Redestad <redestad@openjdk.org> wrote:
Extract some common behavior checks from the generated VarHandleGuards code to a package-private VarHandle method. This reduces the code size (-5.2kb lib/modules) and slightly improves startup, while being performance neutral on microbenchmarks.
Paul, Mandy, thanks for reviewing ------------- PR: https://git.openjdk.java.net/jdk/pull/4165
On Mon, 24 May 2021 11:47:53 GMT, Claes Redestad <redestad@openjdk.org> wrote:
Extract some common behavior checks from the generated VarHandleGuards code to a package-private VarHandle method. This reduces the code size (-5.2kb lib/modules) and slightly improves startup, while being performance neutral on microbenchmarks.
This pull request has now been integrated. Changeset: c519ba2e Author: Claes Redestad <redestad@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/c519ba2e437a05ac83e53b358b6a02b2f6e2... Stats: 338 lines in 3 files changed: 14 ins; 243 del; 81 mod 8267614: Outline VarHandleGuards exact behavior checks Reviewed-by: psandoz, mchung ------------- PR: https://git.openjdk.java.net/jdk/pull/4165
participants (3)
-
Claes Redestad
-
Mandy Chung
-
Paul Sandoz