Re: RFR(XXS): 8130315: Fix wrong prototype of GrowKnownVMs() in java.c
On 02/07/2015 13:43, Volker Simonis wrote:
Hi,
could someone please review this tiny fix:
http://cr.openjdk.java.net/~simonis/webrevs/2015/8130315/ https://bugs.openjdk.java.net/browse/JDK-8130315
Because of this bug jdk9 doesn't build without '--disable-warnings-as-errors' on SLES 12 with gcc 4.8.3
(moving this to core-libs-dev). This looks right. -Alan.
Thanks Alan and sorry for choosing the wrong list once again :) Volker On Thu, Jul 2, 2015 at 2:48 PM, Alan Bateman <Alan.Bateman@oracle.com> wrote:
On 02/07/2015 13:43, Volker Simonis wrote:
Hi,
could someone please review this tiny fix:
http://cr.openjdk.java.net/~simonis/webrevs/2015/8130315/ https://bugs.openjdk.java.net/browse/JDK-8130315
Because of this bug jdk9 doesn't build without '--disable-warnings-as-errors' on SLES 12 with gcc 4.8.3
(moving this to core-libs-dev).
This looks right.
-Alan.
Looks good and thanks for fixing this. I have marked the jbs issue with a "noreg-trivial". Kumar On 7/2/2015 6:03 AM, Volker Simonis wrote:
Thanks Alan and sorry for choosing the wrong list once again :)
Volker
On Thu, Jul 2, 2015 at 2:48 PM, Alan Bateman <Alan.Bateman@oracle.com> wrote:
On 02/07/2015 13:43, Volker Simonis wrote:
Hi,
could someone please review this tiny fix:
http://cr.openjdk.java.net/~simonis/webrevs/2015/8130315/ https://bugs.openjdk.java.net/browse/JDK-8130315
Because of this bug jdk9 doesn't build without '--disable-warnings-as-errors' on SLES 12 with gcc 4.8.3
(moving this to core-libs-dev).
This looks right.
-Alan.
Thanks Kumar! On Thu, Jul 2, 2015 at 3:09 PM, Kumar Srinivasan <kumar.x.srinivasan@oracle.com> wrote:
Looks good and thanks for fixing this.
I have marked the jbs issue with a "noreg-trivial".
Kumar
On 7/2/2015 6:03 AM, Volker Simonis wrote:
Thanks Alan and sorry for choosing the wrong list once again :)
Volker
On Thu, Jul 2, 2015 at 2:48 PM, Alan Bateman <Alan.Bateman@oracle.com> wrote:
On 02/07/2015 13:43, Volker Simonis wrote:
Hi,
could someone please review this tiny fix:
http://cr.openjdk.java.net/~simonis/webrevs/2015/8130315/ https://bugs.openjdk.java.net/browse/JDK-8130315
Because of this bug jdk9 doesn't build without '--disable-warnings-as-errors' on SLES 12 with gcc 4.8.3
(moving this to core-libs-dev).
This looks right.
-Alan.
participants (3)
-
Alan Bateman
-
Kumar Srinivasan
-
Volker Simonis