RFR: JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution.
We are backing out the fix to "JDK-8248904 Add support to jpackage for the Mac App Store " in order to resubmit with added contributor attribution for Erwin Morrhey This is the backout. ------------- Commit messages: - JDK-8264055: backout JDK-8248904 in order to resubmit with additional attribution. Changes: https://git.openjdk.java.net/jdk/pull/3159/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3159&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264055 Stats: 310 lines in 22 files changed: 41 ins; 205 del; 64 mod Patch: https://git.openjdk.java.net/jdk/pull/3159.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3159/head:pull/3159 PR: https://git.openjdk.java.net/jdk/pull/3159
On Tue, 23 Mar 2021 17:09:20 GMT, Andy Herrick <herrick@openjdk.org> wrote:
We are backing out the fix to "JDK-8248904 Add support to jpackage for the Mac App Store " in order to resubmit with added contributor attribution for Erwin Morrhey This is the backout.
Looks good, although i see the following wasn't backed out: src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns If this is intentional, then no need to worry about it. ------------- Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk/pull/3159
On Tue, 23 Mar 2021 17:55:24 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:
Looks good, although i see the following wasn't backed out:
``` src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns ```
yes - look again - it was renamed back to java.icns (the 12'th or 22 files changed above) ------------- PR: https://git.openjdk.java.net/jdk/pull/3159
On Tue, 23 Mar 2021 18:17:00 GMT, Andy Herrick <herrick@openjdk.org> wrote:
Looks good, although i see the following wasn't backed out:
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns
If this is intentional, then no need to worry about it.
Looks good, although i see the following wasn't backed out:
``` src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns ```
yes - look again - it was renamed back to java.icns (the 12'th or 22 files changed above)
As long as there are no transient build/test failures, it will be fine. I was just comparing the results with what `git revert 11c8c78c47f21fcd87a5969a859b5c4fced5e47d` generated and noticed this difference. ------------- PR: https://git.openjdk.java.net/jdk/pull/3159
On Tue, 23 Mar 2021 19:40:38 GMT, Kevin Rushforth <kcr@openjdk.org> wrote:
Looks good, although i see the following wasn't backed out:
``` src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns ```
yes - look again - it was renamed back to java.icns (the 12'th or 22 files changed above)
As long as there are no transient build/test failures, it will be fine. I was just comparing the results with what `git revert 11c8c78c47f21fcd87a5969a859b5c4fced5e47d` generated and noticed this difference.
@sashamatveev please review ------------- PR: https://git.openjdk.java.net/jdk/pull/3159
On Tue, 23 Mar 2021 20:42:22 GMT, Victor Dyakov <vdyakov@openjdk.org> wrote:
As long as there are no transient build/test failures, it will be fine. I was just comparing the results with what `git revert 11c8c78c47f21fcd87a5969a859b5c4fced5e47d` generated and noticed this difference.
@sashamatveev please review
@alexeysemenyukoracle please review ------------- PR: https://git.openjdk.java.net/jdk/pull/3159
On Tue, 23 Mar 2021 17:09:20 GMT, Andy Herrick <herrick@openjdk.org> wrote:
We are backing out the fix to "JDK-8248904 Add support to jpackage for the Mac App Store " in order to resubmit with added contributor attribution for Erwin Morrhey This is the backout.
Marked as reviewed by asemenyuk (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/3159
On Tue, 23 Mar 2021 17:09:20 GMT, Andy Herrick <herrick@openjdk.org> wrote:
We are backing out the fix to "JDK-8248904 Add support to jpackage for the Mac App Store " in order to resubmit with added contributor attribution for Erwin Morrhey This is the backout.
This pull request has now been integrated. Changeset: 15bcf6d9 Author: Andy Herrick <herrick@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/15bcf6d9 Stats: 310 lines in 22 files changed: 41 ins; 205 del; 64 mod 8264055: backout JDK-8248904 in order to resubmit with additional attribution. Reviewed-by: kcr, asemenyuk ------------- PR: https://git.openjdk.java.net/jdk/pull/3159
participants (4)
-
Alexey Semenyuk
-
Andy Herrick
-
Kevin Rushforth
-
Victor Dyakov