[verona.stage] RFR 8134365: Test test/sun/misc/Version/Version.java should follow Verona rules for trailing zeros
Please review this change: Bug: https://bugs.openjdk.java.net/browse/JDK-8134365 Webrev: http://cr.openjdk.java.net/~amurillo/9/8134365/ This change modifies the toString() method of: test/sun/misc/Version/Version.java so that it doesn't include trailing zeros when the some version fields are not defined. For example, if the version is 9-ea+b2, "toString()" should not return 9.0.0.0-ea+b2 note that this class will eventually be modified to use the Java API to parse, validate, and compare version strings once it is available. That's being tracked under: https://bugs.openjdk.java.net/browse/JDK-8136651 Thanks -- Alejandro
On Sep 16, 2015, at 11:23 AM, Alejandro E Murillo <alejandro.murillo@oracle.com> wrote:
Please review this change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8134365 Webrev: http://cr.openjdk.java.net/~amurillo/9/8134365/
This change modifies the toString() method of: test/sun/misc/Version/Version.java so that it doesn't include trailing zeros when the some version fields are not defined. For example, if the version is 9-ea+b2, "toString()" should not return 9.0.0.0-ea+b2
This looks okay to me. Mandy
On 9/16/2015 6:44 PM, Mandy Chung wrote:
On Sep 16, 2015, at 11:23 AM, Alejandro E Murillo <alejandro.murillo@oracle.com> wrote:
Please review this change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8134365 Webrev: http://cr.openjdk.java.net/~amurillo/9/8134365/
This change modifies the toString() method of: test/sun/misc/Version/Version.java so that it doesn't include trailing zeros when the some version fields are not defined. For example, if the version is 9-ea+b2, "toString()" should not return 9.0.0.0-ea+b2 This looks okay to me.
Mandy
Thanks Mandy -- Alejandro
participants (2)
-
Alejandro E Murillo
-
Mandy Chung