RFR: JDK-8219695: Use a copy of javac's implementation of @argfile in jpackager
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The fix is to include the code for processing @argfile from javac into jpackage. [1] https://bugs.openjdk.java.net/browse/JDK-8219695 [2] http://cr.openjdk.java.net/~herrick/8219695/ /Andy
Looks good to me. -- Kevin On 2/26/2019 5:20 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).
The fix is to include the code for processing @argfile from javac into jpackage.
[1] https://bugs.openjdk.java.net/browse/JDK-8219695
[2] http://cr.openjdk.java.net/~herrick/8219695/
/Andy
Hi, The copyright in CommandLine.java should be 2019, the package declaration changed, though probably nothing else. $.02, Roger On 02/26/2019 08:35 AM, Kevin Rushforth wrote:
Looks good to me.
-- Kevin
On 2/26/2019 5:20 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).
The fix is to include the code for processing @argfile from javac into jpackage.
[1] https://bugs.openjdk.java.net/browse/JDK-8219695
[2] http://cr.openjdk.java.net/~herrick/8219695/
/Andy
participants (3)
-
Andy Herrick
-
Kevin Rushforth
-
Roger Riggs