RFR: JDK-8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string
The fix adds "-XX:PerfMaxStringConstLength" argument running target app (default is 1024, 8K should be enough for any environments) ------------- Commit messages: - JDK-8274930 Changes: https://git.openjdk.java.net/jdk/pull/5858/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5858&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274930 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5858.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5858/head:pull/5858 PR: https://git.openjdk.java.net/jdk/pull/5858
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov <amenkov@openjdk.org> wrote:
The fix adds "-XX:PerfMaxStringConstLength" argument running target app (default is 1024, 8K should be enough for any environments)
LGTM. Thanks, Serguei ------------- Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5858
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov <amenkov@openjdk.org> wrote:
The fix adds "-XX:PerfMaxStringConstLength" argument running target app (default is 1024, 8K should be enough for any environments)
Ping. Need 2nd reviewer ------------- PR: https://git.openjdk.java.net/jdk/pull/5858
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov <amenkov@openjdk.org> wrote:
The fix adds "-XX:PerfMaxStringConstLength" argument running target app (default is 1024, 8K should be enough for any environments)
Marked as reviewed by cjplummer (Reviewer). Actually revoking my review for the moment. Do we have any tests that currently test the default PerfMaxStringConstLength, and this change could be subverting the test by making it so the length is never exceeded? ------------- PR: https://git.openjdk.java.net/jdk/pull/5858
participants (3)
-
Alex Menkov
-
Chris Plummer
-
Serguei Spitsyn