On 2018/9/4 3:14 PM, Alan Bateman wrote:

On 04/09/2018 06:41, Amy Lu wrote:

...

test/jdk/jdk/internal/reflect/Reflection/GetCallerClassTest.sh

Please review this patch to refactor above shell script test to java.

bug: https://bugs.openjdk.java.net/browse/JDK-8209832 webrev: http://cr.openjdk.java.net/~amlu/8209832/webrev.00/ This looks okay. If you want, you can reduce the code in SetupGetCallerClass by replacing the initialization of dest with Path.of("bcp", "boot") as userDir is not needed. Also the nonExists check isn't needed either.

-Alan

Thank you Alan! I updated SetupGetCallerClass: http://cr.openjdk.java.net/~amlu/8209832/webrev.01/ Thanks, Amy

On 9/4/18 2:26 AM, Amy Lu wrote:

I updated SetupGetCallerClass: http://cr.openjdk.java.net/~amlu/8209832/webrev.01/

Looks fine to me. Mandy