RFR (XS) JDK-8051861 [TESTBUG] test "java/math/BigInteger/BigIntegerTest.java" does not hold Random value to have a possibility to reproduce it
Hi, Please review and help me with integration: Problem: java.math.BigInteger.BigIntegerTest uses java.math.Random(), so we have no possibility to reproduce it. Solution: Test gets start random seed from environment variable. If this variable not exists, test write current random seed to log. Bug: https://bugs.openjdk.java.net/browse/JDK-8051861 Fix: (in attachment) Best regards, Vasily
Hi, Please review and help me with integration: Problem: java.math.BigInteger.BigIntegerTest uses java.math.Random(), so we have no possibility to reproduce it. Solution: Test gets start random seed from environment variable. If this variable not exists, test write current random seed to log. Bug: https://bugs.openjdk.java.net/browse/JDK-8051861 Fix: (in attachment) Best regards, Vasily
Hello, If you are going to report the seed to the test log, that should be done unconditionally regardless of whether a passed in seed is being used. Cheers, -Joe On 7/24/2014 7:39 AM, vasily stolbov wrote:
Hi,
Please review and help me with integration:
Problem: java.math.BigInteger.BigIntegerTest uses java.math.Random(), so we have no possibility to reproduce it.
Solution: Test gets start random seed from environment variable. If this variable not exists, test write current random seed to log.
Bug: https://bugs.openjdk.java.net/browse/JDK-8051861 Fix: (in attachment)
Best regards, Vasily
Hi! Fixed. On 24.07.2014 19:52, Joe Darcy wrote:
If you are going to report the seed to the test log, that should be done unconditionally regardless of whether a passed in seed is being used.
Hi, Please review and help me with integration: Problem: java.math.BigInteger.BigIntegerTest uses java.math.Random(), so we have no possibility to reproduce it. Solution: Test gets start random seed from environment variable. If this variable not exists, test write current random seed to log. Bug: https://bugs.openjdk.java.net/browse/JDK-8051861 Fix: (in attachment) Best regards, Vasily
-------- Original Message -------- Subject: RFR (XS) JDK-8051861 [TESTBUG] test "java/math/BigInteger/BigIntegerTest.java" does not hold Random value to have a possibility to reproduce it Date: Mon, 04 Aug 2014 17:45:02 +0400 From: vasily stolbov <vasily.stolbov@oracle.com> Organization: Oracle Corporation To: core-libs-dev@openjdk.java.net Hi, Please review and help me with integration: Problem: java.math.BigInteger.BigIntegerTest uses java.math.Random(), so we have no possibility to reproduce it. Solution: Test gets start random seed from environment variable. If this variable not exists, test write current random seed to log. Bug: https://bugs.openjdk.java.net/browse/JDK-8051861 Fix: (in attachment) Best regards, Vasily
participants (2)
-
Joe Darcy
-
vasily stolbov