Hi Vipin, Test code changes looks good to me as well except copyright changes, which will be fix at the time of pushing the code by Christoph. Thanks, Vyom On Fri, Mar 6, 2020 at 12:06 PM Langer, Christoph <christoph.langer@sap.com> wrote:

Hi Vipin,

this all looks correct to me.

When changing the copyright headers, you have to keep the first (initial) year and only update the second year. If this doesn’t exist, you’ll have to add it, e.g. Copyright (c) 1999, Oracle -> Copyright (c) 1999, 2020, Oracle

I can fix that for you though, when sponsoring, no need for new webrev.

Can I have a second review, please?

Thanks Christoph

From: Vipin Sharma <vipinsharma85@gmail.com> Sent: Donnerstag, 5. März 2020 18:27 To: Langer, Christoph <christoph.langer@sap.com>; core-libs-dev@openjdk.java.net Subject: RFR 8240524: Removed warnings from test classes

Hi All,

Please review patch to remove warnings from test classes.

Bug : https://bugs.openjdk.java.net/browse/JDK-8240524 Webrev : http://cr.openjdk.java.net/~clanger/webrevs/8240524.0/

Change description:

Class: test/jdk/java/lang/Boolean/GetBoolean.java Fixed following warning: 1. "Exception 'java.lang.Exception' is never thrown in the method”

Class: test/jdk/java/lang/Boolean/MakeBooleanComparable.java Fixed following warnings: 1. Explicit type argument Boolean can be replaced with <> 2. C-style array declaration of parameter 'args'

Class: test/jdk/java/lang/Boolean/ParseBoolean.java Fixed following warning: 1. Exception 'java.lang.Exception' is never thrown in the method

Regards, Vipin

-- Thanks, Vyom