RFR: 8377388: Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'. ------------- Commit messages: - 8377388: Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner Changes: https://git.openjdk.org/jdk/pull/29627/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29627&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8377388 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/29627.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29627/head:pull/29627 PR: https://git.openjdk.org/jdk/pull/29627
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
This looks OK to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29627#pullrequestreview-3784170624
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
@mkarg I assume you will create the CSR for this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29627#issuecomment-3883924689
On Wed, 11 Feb 2026 11:46:05 GMT, Alan Bateman <alanb@openjdk.org> wrote:
@mkarg I assume you will create the CSR for this.
Yes, typing it right in this very moment. :-) ------------- PR Comment: https://git.openjdk.org/jdk/pull/29627#issuecomment-3883929526
On Wed, 11 Feb 2026 11:47:13 GMT, Markus KARG <duke@openjdk.org> wrote:
@mkarg I assume you will create the CSR for this.
Kindly asking for reviews on CSR draft https://bugs.openjdk.org/browse/JDK-8377660. Thank you. :-) ------------- PR Comment: https://git.openjdk.org/jdk/pull/29627#issuecomment-3883964196
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
Looks good. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29627#pullrequestreview-3785360695
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
Looks fine. ------------- Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29627#pullrequestreview-3786377117
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
I ran this change in our CI with the latest mainline, and tier1, tier2 and tier3 tests completed without any related issues. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29627#issuecomment-3920244422
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
Could someone please sponsor this change? ------------- PR Comment: https://git.openjdk.org/jdk/pull/29627#issuecomment-3933680301
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
Please issue a "/integrate" which then allows this to be sponsored. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29627#issuecomment-3933723218
On Fri, 20 Feb 2026 12:07:17 GMT, Jaikiran Pai <jpai@openjdk.org> wrote:
Please issue a "/integrate" which then allows this to be sponsored.
Done, but Skara did not pick it up. Maybe you need to explicitly mark this PR as "reviewed" first? 🤔 ------------- PR Comment: https://git.openjdk.org/jdk/pull/29627#issuecomment-3936027732
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
@mkarg Your change (at version 03837bb46aeb4c907af0fef8063f461aceaf079a) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29627#issuecomment-3936032533
On Mon, 9 Feb 2026 07:33:03 GMT, Markus KARG <duke@openjdk.org> wrote:
This Pull Request provides an implementation for [JDK-8377388](https://bugs.openjdk.org/browse/JDK-8377388): 'Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner'.
This pull request has now been integrated. Changeset: bc971b51 Author: Markus KARG <markus@headcrashing.eu> Committer: Jaikiran Pai <jpai@openjdk.org> URL: https://git.openjdk.org/jdk/commit/bc971b51b9a27b8b026f6fbbe1b0d49e7b702a6c Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8377388: Replacing "new StringReader(String)" by "Reader.of(CharSequence);" in Scanner Reviewed-by: jpai, rriggs, bpb ------------- PR: https://git.openjdk.org/jdk/pull/29627
participants (6)
-
Alan Bateman
-
Brian Burkhalter
-
duke
-
Jaikiran Pai
-
Markus KARG
-
Roger Riggs