RFR(M) : 8182404 : remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher
http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html
327 lines changed: 13 ins; 270 del; 44 mod;
Hi all, could you please review the patch which removes jdk.testlibrary.JDKToolFinder and JDKToolLauncher and replaces their usages w/ jdk.test.lib.JDKToolFinder and JDKToolLauncher respectively? JBS: https://bugs.openjdk.java.net/browse/JDK-8182404 webrev: http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html testing: tier1-3 + :jdk_svc Thanks, -- Igor
Hi Igor, Looks good. --alex On 09/07/2018 15:11, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html
327 lines changed: 13 ins; 270 del; 44 mod;
Hi all,
could you please review the patch which removes jdk.testlibrary.JDKToolFinder and JDKToolLauncher and replaces their usages w/ jdk.test.lib.JDKToolFinder and JDKToolLauncher respectively?
JBS: https://bugs.openjdk.java.net/browse/JDK-8182404 webrev: http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html testing: tier1-3 + :jdk_svc
Thanks, -- Igor
Hi Igor, Looks good to me as well, nice job :-) Jc On Fri, Sep 7, 2018 at 5:46 PM Alex Menkov <alexey.menkov@oracle.com> wrote:
Hi Igor,
Looks good.
--alex
On 09/07/2018 15:11, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html
327 lines changed: 13 ins; 270 del; 44 mod;
Hi all,
could you please review the patch which removes jdk.testlibrary.JDKToolFinder and JDKToolLauncher and replaces their usages w/ jdk.test.lib.JDKToolFinder and JDKToolLauncher respectively?
JBS: https://bugs.openjdk.java.net/browse/JDK-8182404 webrev: http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html testing: tier1-3 + :jdk_svc
Thanks, -- Igor
-- Thanks, Jc
On 07/09/2018 23:11, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8182404/webrev.00/index.html
I skimmed through the changes and they look okay. One test to check is PatchSystemModules as it looks like /lib/testlibrary can be dropped from its @library tag. -Alan
participants (4)
-
Alan Bateman
-
Alex Menkov
-
Igor Ignatyev
-
JC Beyler