RFR 8189330 Cleanup FileDescriptor implementation
Please review a cleanup and refactoring of FileDescriptor.java. The Unix and Windows versions are merged to ease maintenance remove replicated code The FileCleanable class is extracted and SocketCleanable is updated. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-fd-cleanup-8189330/ Issue: https://bugs.openjdk.java.net/browse/JDK-8189330 Thanks, Roger
Hi Roger, I think that this looks fine. I assume the issue should be labelled “noreg-cleanup." Brian On Feb 16, 2018, at 2:28 PM, Roger Riggs <Roger.Riggs@Oracle.com> wrote:
Please review a cleanup and refactoring of FileDescriptor.java. The Unix and Windows versions are merged to ease maintenance remove replicated code The FileCleanable class is extracted and SocketCleanable is updated.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-fd-cleanup-8189330/
participants (2)
-
Brian Burkhalter
-
Roger Riggs