RFR: 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root
Please review this test fix to work around a podman issue[1]. `podman` expects for the "unlimited" option of `--pids-limit` to be `0` whereas `docker` wants `-1`. See the JBS bug for details. Thoughts? Testing: hotspot/jdk container tests with docker and podman. Two pids tests used to fail and pass with the patch. [1] https://github.com/containers/podman/issues/11782 ------------- Commit messages: - 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root Changes: https://git.openjdk.java.net/jdk/pull/5750/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5750&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274506 Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/5750.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5750/head:pull/5750 PR: https://git.openjdk.java.net/jdk/pull/5750
On Wed, 29 Sep 2021 12:51:00 GMT, Severin Gehwolf <sgehwolf@openjdk.org> wrote:
Please review this test fix to work around a podman issue[1]. `podman` expects for the "unlimited" option of `--pids-limit` to be `0` whereas `docker` wants `-1`. See the JBS bug for details. Thoughts?
Testing: hotspot/jdk container tests with docker and podman. Two pids tests used to fail and pass with the patch.
Hello Severin, the test fix looks good to me. Best regards, Matthias ------------- Marked as reviewed by mbaesken (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5750
On Wed, 29 Sep 2021 12:51:00 GMT, Severin Gehwolf <sgehwolf@openjdk.org> wrote:
Please review this test fix to work around a podman issue[1]. `podman` expects for the "unlimited" option of `--pids-limit` to be `0` whereas `docker` wants `-1`. See the JBS bug for details. Thoughts?
Testing: hotspot/jdk container tests with docker and podman. Two pids tests used to fail and pass with the patch.
Thanks for the review! ------------- PR: https://git.openjdk.java.net/jdk/pull/5750
On Wed, 29 Sep 2021 12:51:00 GMT, Severin Gehwolf <sgehwolf@openjdk.org> wrote:
Please review this test fix to work around a podman issue[1]. `podman` expects for the "unlimited" option of `--pids-limit` to be `0` whereas `docker` wants `-1`. See the JBS bug for details. Thoughts?
Testing: hotspot/jdk container tests with docker and podman. Two pids tests used to fail and pass with the patch.
Marked as reviewed by cjplummer (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/5750
On Wed, 29 Sep 2021 12:51:00 GMT, Severin Gehwolf <sgehwolf@openjdk.org> wrote:
Please review this test fix to work around a podman issue[1]. `podman` expects for the "unlimited" option of `--pids-limit` to be `0` whereas `docker` wants `-1`. See the JBS bug for details. Thoughts?
Testing: hotspot/jdk container tests with docker and podman. Two pids tests used to fail and pass with the patch.
This pull request has now been integrated. Changeset: 94e31e5c Author: Severin Gehwolf <sgehwolf@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/94e31e5ca51d1c4c253cf7ac5acd950d10c2... Stats: 12 lines in 2 files changed: 10 ins; 0 del; 2 mod 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root Reviewed-by: mbaesken, cjplummer ------------- PR: https://git.openjdk.java.net/jdk/pull/5750
participants (3)
-
Chris Plummer
-
Matthias Baesken
-
Severin Gehwolf