[8u-dev] RFR (JAXP) 8028363: XmlGregorianCalendarImpl.getTimeZone() bug when offset is less than 10 minutes
Hello, please review this fix for 8u-dev. For jdk9 problem has been addressed in JEP 255 <https://bugs.openjdk.java.net/browse/JDK-8044086> (Xerces update). Please note that changeset contains of 2 parts: XMLGregorianCalendarImpl fix in jaxp ws: http://cr.openjdk.java.net/~snikandrova/8028363/jaxp/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jaxp/webrev.00/> Regression test in jdk ws: http://cr.openjdk.java.net/~snikandrova/8028363/jdk/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jdk/webrev.00/> JBS: https://bugs.openjdk.java.net/browse/JDK-8028363 Description: While concatenating timezone representations string for TimeZone.getTimeZone() XmlGregorianCalendarImpl missed prior "0" in minutes part if minutes value is less then 10 (like "0" in 11:05). Thank you, Svetlana <https://bugs.openjdk.java.net/browse/JDK-8044086>
Little reminder. On 19.07.2016 19:29, Svetlana Nikandrova wrote:
Hello,
please review this fix for 8u-dev. For jdk9 problem has been addressed in JEP 255 <https://bugs.openjdk.java.net/browse/JDK-8044086> (Xerces update). Please note that changeset contains of 2 parts: XMLGregorianCalendarImpl fix in jaxp ws: http://cr.openjdk.java.net/~snikandrova/8028363/jaxp/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jaxp/webrev.00/> Regression test in jdk ws: http://cr.openjdk.java.net/~snikandrova/8028363/jdk/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jdk/webrev.00/>
JBS: https://bugs.openjdk.java.net/browse/JDK-8028363
Description: While concatenating timezone representations string for TimeZone.getTimeZone() XmlGregorianCalendarImpl missed prior "0" in minutes part if minutes value is less then 10 (like "0" in 11:05).
Thank you, Svetlana
Hi Svetlana, Looks good. Thanks, Roger On 7/21/2016 8:13 AM, Svetlana Nikandrova wrote:
Little reminder.
On 19.07.2016 19:29, Svetlana Nikandrova wrote:
Hello,
please review this fix for 8u-dev. For jdk9 problem has been addressed in JEP 255 <https://bugs.openjdk.java.net/browse/JDK-8044086> (Xerces update). Please note that changeset contains of 2 parts: XMLGregorianCalendarImpl fix in jaxp ws: http://cr.openjdk.java.net/~snikandrova/8028363/jaxp/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jaxp/webrev.00/> Regression test in jdk ws: http://cr.openjdk.java.net/~snikandrova/8028363/jdk/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jdk/webrev.00/>
JBS: https://bugs.openjdk.java.net/browse/JDK-8028363
Description: While concatenating timezone representations string for TimeZone.getTimeZone() XmlGregorianCalendarImpl missed prior "0" in minutes part if minutes value is less then 10 (like "0" in 11:05).
Thank you, Svetlana
Looks fine to me also Svetlana. Regards, Sean. On 21/07/2016 13:13, Svetlana Nikandrova wrote:
Little reminder.
On 19.07.2016 19:29, Svetlana Nikandrova wrote:
Hello,
please review this fix for 8u-dev. For jdk9 problem has been addressed in JEP 255 <https://bugs.openjdk.java.net/browse/JDK-8044086> (Xerces update). Please note that changeset contains of 2 parts: XMLGregorianCalendarImpl fix in jaxp ws: http://cr.openjdk.java.net/~snikandrova/8028363/jaxp/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jaxp/webrev.00/> Regression test in jdk ws: http://cr.openjdk.java.net/~snikandrova/8028363/jdk/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jdk/webrev.00/>
JBS: https://bugs.openjdk.java.net/browse/JDK-8028363
Description: While concatenating timezone representations string for TimeZone.getTimeZone() XmlGregorianCalendarImpl missed prior "0" in minutes part if minutes value is less then 10 (like "0" in 11:05).
Thank you, Svetlana
+1. -Joe On 7/21/2016 10:40 AM, Seán Coffey wrote:
Looks fine to me also Svetlana.
Regards, Sean.
On 21/07/2016 13:13, Svetlana Nikandrova wrote:
Little reminder.
On 19.07.2016 19:29, Svetlana Nikandrova wrote:
Hello,
please review this fix for 8u-dev. For jdk9 problem has been addressed in JEP 255 <https://bugs.openjdk.java.net/browse/JDK-8044086> (Xerces update). Please note that changeset contains of 2 parts: XMLGregorianCalendarImpl fix in jaxp ws: http://cr.openjdk.java.net/~snikandrova/8028363/jaxp/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jaxp/webrev.00/> Regression test in jdk ws: http://cr.openjdk.java.net/~snikandrova/8028363/jdk/webrev.00/ <http://cr.openjdk.java.net/%7Esnikandrova/8028363/jdk/webrev.00/>
JBS: https://bugs.openjdk.java.net/browse/JDK-8028363
Description: While concatenating timezone representations string for TimeZone.getTimeZone() XmlGregorianCalendarImpl missed prior "0" in minutes part if minutes value is less then 10 (like "0" in 11:05).
Thank you, Svetlana
participants (4)
-
huizhe wang
-
Roger Riggs
-
Seán Coffey
-
Svetlana Nikandrova