Hi Chris, Thank you if you can be the sponsor. Yes, it is very small probability as we executed the test on a local machine for 200 times on a local machine, but failed only 2 times. Regards, Eric On 2013/3/5 1:55, Chris Hegarty wrote:

Eric,

The change looks fine to me, although I have to admit I never seen this test fail before ( though I do see the small race window ).

Let me know if you need a sponsor for this.

-Chris.

On 03/04/2013 04:13 PM, Eric Wang wrote:

...

Hi,

Please help to review the fix below for bug 8009259 <https://jbs.oracle.com/bugs/browse/JDK-8009259> TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently. http://cr.openjdk.java.net/~ewang/8009259/webrev.00/

The test failed due to wrong assumption of thread scheduling, so fix it to make test passes if exception thrown or fails if jtreg execution timeout.

Thanks, Eric

On 2013/3/5 2:25, Alan Bateman wrote:

On 04/03/2013 16:13, Eric Wang wrote:

...

Hi,

Please help to review the fix below for bug 8009259 <https://jbs.oracle.com/bugs/browse/JDK-8009259> TEST_BUG: sun/misc/Cleaner/exitOnThrow.sh failing intermittently. http://cr.openjdk.java.net/~ewang/8009259/webrev.00/

The test failed due to wrong assumption of thread scheduling, so fix it to make test passes if exception thrown or fails if jtreg execution timeout. I don't I've seen it fail either but I assume the Cleaner's System.exit terminates the VM before the the main thread gets to its System.exit(0). The change look good to me. One suggestion is to add 8009259 to the shell script that runs it.

-Alan

Have updated, please review, Thanks! http://cr.openjdk.java.net/~ewang/8009259/webrev.01/ Eric