RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures.
Hi, Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed. https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/ Thanks, Joe
Looks ok joe
On May 15, 2020, at 1:54 PM, Joe Wang <huizhe.wang@oracle.com> wrote:
Hi,
Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed.
https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
Thanks, Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com <mailto:Lance.Andersen@oracle.com>
+1 Naoto On 5/15/20 11:35 AM, Lance Andersen wrote:
Looks ok joe
On May 15, 2020, at 1:54 PM, Joe Wang <huizhe.wang@oracle.com> wrote:
Hi,
Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed.
https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
Thanks, Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com <mailto:Lance.Andersen@oracle.com>
Hi Joe, Looks good, thanks for the cleanup. Roger On 5/15/20 2:39 PM, naoto.sato@oracle.com wrote:
+1
Naoto
On 5/15/20 11:35 AM, Lance Andersen wrote:
Looks ok joe
On May 15, 2020, at 1:54 PM, Joe Wang <huizhe.wang@oracle.com> wrote:
Hi,
Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed.
https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
Thanks, Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com <mailto:Lance.Andersen@oracle.com>
Hi Joe, do your changes warrant a java doc change for readObject in each LocPathIterator PredicatedNodeTest, and UnionPathIterator ? regards Mark ________________________________ From: core-libs-dev <core-libs-dev-bounces@openjdk.java.net> on behalf of Joe Wang <huizhe.wang@oracle.com> Sent: Friday 15 May 2020 17:54 To: core-libs-dev@openjdk.java.net <core-libs-dev@openjdk.java.net> Subject: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Hi, Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed. https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/ Thanks, Joe
Thanks Mark! I missed that, and I was also 20 min too fast on the checkin :-) Here's a catch-up patch, pls review: http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/ -Joe On 5/18/2020 10:21 AM, mark sheppard wrote:
Hi Joe, do your changes warrant a java doc change for readObject in each LocPathIterator PredicatedNodeTest, and UnionPathIterator ?
regards Mark
------------------------------------------------------------------------ *From:* core-libs-dev <core-libs-dev-bounces@openjdk.java.net> on behalf of Joe Wang <huizhe.wang@oracle.com> *Sent:* Friday 15 May 2020 17:54 *To:* core-libs-dev@openjdk.java.net <core-libs-dev@openjdk.java.net> *Subject:* RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Hi,
Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed.
https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
Thanks, Joe
Hi Joe, all good I think. 👍 regards Mark ________________________________ From: Joe Wang <huizhe.wang@oracle.com> Sent: Monday 18 May 2020 19:36 To: mark sheppard <macanaoire@hotmail.com>; core-libs-dev@openjdk.java.net <core-libs-dev@openjdk.java.net> Cc: Mark Sheppard <mark.sheppard@oracle.com> Subject: Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Thanks Mark! I missed that, and I was also 20 min too fast on the checkin :-) Here's a catch-up patch, pls review: http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/ -Joe On 5/18/2020 10:21 AM, mark sheppard wrote: Hi Joe, do your changes warrant a java doc change for readObject in each LocPathIterator PredicatedNodeTest, and UnionPathIterator ? regards Mark ________________________________ From: core-libs-dev <core-libs-dev-bounces@openjdk.java.net><mailto:core-libs-dev-bounces@openjdk.java.net> on behalf of Joe Wang <huizhe.wang@oracle.com><mailto:huizhe.wang@oracle.com> Sent: Friday 15 May 2020 17:54 To: core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net> <core-libs-dev@openjdk.java.net><mailto:core-libs-dev@openjdk.java.net> Subject: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Hi, Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed. https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/ Thanks, Joe
Thanks Mark. -Joe On 5/18/2020 1:49 PM, mark sheppard wrote:
Hi Joe,
all good I think. 👍
regards Mark
------------------------------------------------------------------------ *From:* Joe Wang <huizhe.wang@oracle.com> *Sent:* Monday 18 May 2020 19:36 *To:* mark sheppard <macanaoire@hotmail.com>; core-libs-dev@openjdk.java.net <core-libs-dev@openjdk.java.net> *Cc:* Mark Sheppard <mark.sheppard@oracle.com> *Subject:* Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Thanks Mark! I missed that, and I was also 20 min too fast on the checkin :-)
Here's a catch-up patch, pls review: http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/
-Joe
On 5/18/2020 10:21 AM, mark sheppard wrote:
Hi Joe, do your changes warrant a java doc change for readObject in each LocPathIterator PredicatedNodeTest, and UnionPathIterator ?
regards Mark
------------------------------------------------------------------------ *From:* core-libs-dev <core-libs-dev-bounces@openjdk.java.net> <mailto:core-libs-dev-bounces@openjdk.java.net> on behalf of Joe Wang <huizhe.wang@oracle.com> <mailto:huizhe.wang@oracle.com> *Sent:* Friday 15 May 2020 17:54 *To:* core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> <core-libs-dev@openjdk.java.net> <mailto:core-libs-dev@openjdk.java.net> *Subject:* RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Hi,
Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed.
https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
Thanks, Joe
As it appears, I was missing a comma in the header as well (see https://bugs.openjdk.java.net/browse/JDK-8245238) The webrev is updated with the comma added (to PredicatedNodeTest.java) http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/ Thanks, Joe On 5/18/2020 1:53 PM, Joe Wang wrote:
Thanks Mark.
-Joe
On 5/18/2020 1:49 PM, mark sheppard wrote:
Hi Joe,
all good I think. 👍
regards Mark
------------------------------------------------------------------------ *From:* Joe Wang <huizhe.wang@oracle.com> *Sent:* Monday 18 May 2020 19:36 *To:* mark sheppard <macanaoire@hotmail.com>; core-libs-dev@openjdk.java.net <core-libs-dev@openjdk.java.net> *Cc:* Mark Sheppard <mark.sheppard@oracle.com> *Subject:* Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Thanks Mark! I missed that, and I was also 20 min too fast on the checkin :-)
Here's a catch-up patch, pls review: http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/
-Joe
On 5/18/2020 10:21 AM, mark sheppard wrote:
Hi Joe, do your changes warrant a java doc change for readObject in each LocPathIterator PredicatedNodeTest, and UnionPathIterator ?
regards Mark
------------------------------------------------------------------------
*From:* core-libs-dev <core-libs-dev-bounces@openjdk.java.net> <mailto:core-libs-dev-bounces@openjdk.java.net> on behalf of Joe Wang <huizhe.wang@oracle.com> <mailto:huizhe.wang@oracle.com> *Sent:* Friday 15 May 2020 17:54 *To:* core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> <core-libs-dev@openjdk.java.net> <mailto:core-libs-dev@openjdk.java.net> *Subject:* RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Hi,
Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed.
https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
Thanks, Joe
looks good Joe
On May 18, 2020, at 6:04 PM, Joe Wang <huizhe.wang@oracle.com> wrote:
As it appears, I was missing a comma in the header as well (see https://bugs.openjdk.java.net/browse/JDK-8245238)
The webrev is updated with the comma added (to PredicatedNodeTest.java) http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/
Thanks, Joe
On 5/18/2020 1:53 PM, Joe Wang wrote:
Thanks Mark.
-Joe
On 5/18/2020 1:49 PM, mark sheppard wrote:
Hi Joe,
all good I think. 👍
regards Mark
------------------------------------------------------------------------ *From:* Joe Wang <huizhe.wang@oracle.com> *Sent:* Monday 18 May 2020 19:36 *To:* mark sheppard <macanaoire@hotmail.com>; core-libs-dev@openjdk.java.net <core-libs-dev@openjdk.java.net> *Cc:* Mark Sheppard <mark.sheppard@oracle.com> *Subject:* Re: RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Thanks Mark! I missed that, and I was also 20 min too fast on the checkin :-)
Here's a catch-up patch, pls review: http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/
-Joe
On 5/18/2020 10:21 AM, mark sheppard wrote:
Hi Joe, do your changes warrant a java doc change for readObject in each LocPathIterator PredicatedNodeTest, and UnionPathIterator ?
regards Mark
------------------------------------------------------------------------ *From:* core-libs-dev <core-libs-dev-bounces@openjdk.java.net> <mailto:core-libs-dev-bounces@openjdk.java.net> on behalf of Joe Wang <huizhe.wang@oracle.com> <mailto:huizhe.wang@oracle.com> *Sent:* Friday 15 May 2020 17:54 *To:* core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> <core-libs-dev@openjdk.java.net> <mailto:core-libs-dev@openjdk.java.net> *Subject:* RFR [15] 8244342: Compilation warnings about unexpected serialization related method signatures. Hi,
Please review a fix for the compilation warnings. Thanks Roger for the detailed instructions! If you could verify the fix with the work-in-progress processor, that would be great too. Regular build and test passed.
https://bugs.openjdk.java.net/browse/JDK-8244342 http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
Thanks, Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com <mailto:Lance.Andersen@oracle.com>
participants (5)
-
Joe Wang
-
Lance Andersen
-
mark sheppard
-
naoto.sato＠oracle.com
-
Roger Riggs