On Sep 17, 2014, at 1:52 PM, Alan Bateman <Alan.Bateman@oracle.com> wrote:

On 17/09/2014 21:48, Brian Burkhalter wrote:

...

Hello bad characters,

Issue: https://bugs.openjdk.java.net/browse/JDK-8058679 Webrev: http://cr.openjdk.java.net/~bpb/8058679/webrev.00/

Tested with "-encoding US-ASCII” passed to javac.

\ufffd\ufffd Looks okay and if it compiles with -encoding US-ASCII then it gives confidence that they have all been fixed now.

To be specific: javac -cp ../build/linux-x86-normal-server-fastdebug/jdk/classes -encoding US-ASCII test/java/math/BigInteger/BigIntegerTest.java did not complain. Thanks, Brian

Hi Robert, What happened was that for whatever reason my version of the ‘patch’ command did not like your patch. I tried various things to get ‘patch’ to accept it but without success. Note that this had nothing to do with the modular restructuring of the source tree as the path is easily unshuffled. Consequently I reproduced it manually, copy-pasting the revisions from Firefox into Netbeans on Mac OS 10.9. This is apparently font-preserving but not visible in a webrev and the jcheck tool did not catch it either. In any case, the problems appear to be fixed now. Thanks, Brian On Sep 18, 2014, at 1:52 AM, Robert Gibson <robbiexgibson@yahoo.com> wrote:

Sorry about that, let's blame my crappy webmail ;) (Strange that the patch appears fine in the mail archives and the webrev?) Robert

On Thursday, 18 September 2014, 3:18, Alan Bateman <Alan.Bateman@oracle.com> wrote: On 17/09/2014 21:48, Brian Burkhalter wrote:

...

Hello bad characters,

Issue: https://bugs.openjdk.java.net/browse/JDK-8058679 Webrev: http://cr.openjdk.java.net/~bpb/8058679/webrev.00/

Tested with "-encoding US-ASCII” passed to javac.

\ufffd\ufffd Looks okay and if it compiles with -encoding US-ASCII then it gives confidence that they have all been fixed now.

-Alan