RFR [9] 8080502: Changing accessing module resources
Hi everybody, this is a review request for 8080502: Changing accessing module resources. This change adapts to Jigsaw JDK runtime - it isn't possible to access module resource using Class::getResource() any more. JBS: https://bugs.openjdk.java.net/browse/JDK-8080502 webrev: http://cr.openjdk.java.net/~mkos/8080502/jaxws.01/index.html testing: JAX-WS unit test; basically it is fix for existing tests (JCK, ...) Thanks Miran
On 19/05/2015 10:38, Miroslav Kos wrote:
:
JBS: https://bugs.openjdk.java.net/browse/JDK-8080502 webrev: http://cr.openjdk.java.net/~mkos/8080502/jaxws.01/index.html testing: JAX-WS unit test; basically it is fix for existing tests (JCK, ...) One thing that isn't obvious in this code is where the input streams are closed? Are they closed by whoever is consuming the input stream? Otherwise I don't see any issues.
-Alan
On 21/05/15 14:34, Alan Bateman wrote:
On 19/05/2015 10:38, Miroslav Kos wrote:
:
JBS: https://bugs.openjdk.java.net/browse/JDK-8080502 webrev: http://cr.openjdk.java.net/~mkos/8080502/jaxws.01/index.html testing: JAX-WS unit test; basically it is fix for existing tests (JCK, ...) One thing that isn't obvious in this code is where the input streams are closed? Are they closed by whoever is consuming the input stream? Otherwise I don't see any issues.
-Alan Thanks, you are correct. Changed to try-catch with resources, the some code moved to SchemaCache. Refernced resources found by com.sun.tools.internal.xjc.SchemaCache.ResourceResolver added to collection and closed after parsing.
updated webrev: http://cr.openjdk.java.net/~mkos/8080502/jaxws.02/ tests: rerun standalone tests for bot standalone build and for JDK. Thanks Miran
On 26/05/2015 13:24, Miroslav Kos wrote:
Thanks, you are correct. Changed to try-catch with resources, the some code moved to SchemaCache. Refernced resources found by com.sun.tools.internal.xjc.SchemaCache.ResourceResolver added to collection and closed after parsing.
updated webrev: http://cr.openjdk.java.net/~mkos/8080502/jaxws.02/ tests: rerun standalone tests for bot standalone build and for JDK. This looks much better, it seems to close all the streams now.
There's a TODO-Miran left in MetroConfigLoader that I assume should be looked at before you push. In ParserContext then you could throw InternalError(e) rather than e.getMessage(), assuming of course this doesn't need to compile on JDK 7 or older. -Alan
participants (2)
-
Alan Bateman
-
Miroslav Kos