RFR: 8132379: -J options can cause crash or "Warning: app args parsing error passing arguments as-is"
Hi, Please review a fix for JDK-8132379, the fix is to build matching index to the original arguments for the application arguments, used later for the sanity check and wildcard expansion. The fix is specific to Windows platform. -J prefix used by launcher-based tools such as javac need to be filtered out, but not for java itself, where -J prefix could be used by the main class. Use index table avoid copy of arguments and use less memory. The fix is tested on Windows 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8132379 Webrev: http://cr.openjdk.java.net/~henryjen/jdk9/8132379.0/webrev/ Cheers, Henry
Henry, Thanks for fixing this. Looks good. Kumar
Hi,
Please review a fix for JDK-8132379, the fix is to build matching index to the original arguments for the application arguments, used later for the sanity check and wildcard expansion. The fix is specific to Windows platform.
-J prefix used by launcher-based tools such as javac need to be filtered out, but not for java itself, where -J prefix could be used by the main class.
Use index table avoid copy of arguments and use less memory. The fix is tested on Windows 10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8132379 Webrev: http://cr.openjdk.java.net/~henryjen/jdk9/8132379.0/webrev/
Cheers, Henry
Kumar, Thanks for the review. Cheers, Henry On July 13, 2016 at 6:43:09 AM, Kumar Srinivasan (kumar.x.srinivasan@oracle.com) wrote:
Henry,
Thanks for fixing this. Looks good.
Kumar
Hi,
Please review a fix for JDK-8132379, the fix is to build matching index to the original arguments for the application arguments, used later for the sanity check and wildcard expansion. The fix is specific to Windows platform.
-J prefix used by launcher-based tools such as javac need to be filtered out, but not for java itself, where -J prefix could be used by the main class.
Use index table avoid copy of arguments and use less memory. The fix is tested on Windows
Bug: https://bugs.openjdk.java.net/browse/JDK-8132379 Webrev: http://cr.openjdk.java.net/~henryjen/jdk9/8132379.0/webrev/
Cheers, Henry
participants (2)
-
Henry Jen
-
Kumar Srinivasan