Codereview request for 7033561: Missing Unicode Script aliases
It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we upgraded the Unicode support to 6.0 for JDK7. The difference between the previous version (5.2) and 6.0 of the aliases are these 3 missing names reported in #7033561. The webrev with the change is at http://cr.openjdk.java.net/~sherman/7033561/webrev Thanks, Sherman
Xueming Shen wrote:
It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we upgraded the Unicode support to 6.0 for JDK7. The difference between the previous version (5.2) and 6.0 of the aliases are these 3 missing names reported in #7033561.
The webrev with the change is at
http://cr.openjdk.java.net/~sherman/7033561/webrev
Thanks, Sherman
It looks like test/java/lang/Character/CheckScript.java is missing the GPL header, might be good to add it while you are there. -Alan.
Thanks! webrev has been updated accordingly. -Sherman On 04/06/2011 01:29 PM, Alan Bateman wrote:
Xueming Shen wrote:
It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we upgraded the Unicode support to 6.0 for JDK7. The difference between the previous version (5.2) and 6.0 of the aliases are these 3 missing names reported in #7033561.
The webrev with the change is at
http://cr.openjdk.java.net/~sherman/7033561/webrev
Thanks, Sherman
It looks like test/java/lang/Character/CheckScript.java is missing the GPL header, might be good to add it while you are there.
-Alan.
The fix looks good to me. Masayoshi On 4/7/2011 5:42 AM, Xueming Shen wrote:
Thanks! webrev has been updated accordingly.
-Sherman
On 04/06/2011 01:29 PM, Alan Bateman wrote:
Xueming Shen wrote:
It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we upgraded the Unicode support to 6.0 for JDK7. The difference between the previous version (5.2) and 6.0 of the aliases are these 3 missing names reported in #7033561.
The webrev with the change is at
http://cr.openjdk.java.net/~sherman/7033561/webrev
Thanks, Sherman
It looks like test/java/lang/Character/CheckScript.java is missing the GPL header, might be good to add it while you are there.
-Alan.
Hi Sherman, The fix looks good to me. Thanks, -- Yuka (11/04/07 5:16), Xueming Shen wrote:
It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we upgraded the Unicode support to 6.0 for JDK7. The difference between the previous version (5.2) and 6.0 of the aliases are these 3 missing names reported in #7033561.
The webrev with the change is at
http://cr.openjdk.java.net/~sherman/7033561/webrev
Thanks, Sherman
participants (4)
-
Alan Bateman
-
Masayoshi Okutsu
-
Xueming Shen
-
Yuka Kamiya