Re: RFR: JDK-8244018: No error message for non-existent icon path
revised webrev at [3] - copyrights were updated by previous issue. /Andy [3] http://cr.openjdk.java.net/~herrick/8244018/webrev.02/ On 4/29/2020 4:56 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpac... http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpac... Typo in year: 20120 -> 2020 Otherwise looks fine. Thanks, Alexander On 4/29/20 7:31 AM, Andy Herrick wrote:
Please review fix at [1] for issue [2]
The change just adds error when specified icon is not found, and a test for that.
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8244018/webrev.01/
Hi Andy, Looks good. Thanks, Alexander On 4/30/20 4:18 PM, Andy Herrick wrote:
revised webrev at [3] - copyrights were updated by previous issue.
/Andy
[3] http://cr.openjdk.java.net/~herrick/8244018/webrev.02/
On 4/29/2020 4:56 PM, Alexander Matveev wrote: Hi Andy,
http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpac...
http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpac...
Typo in year: 20120 -> 2020
Otherwise looks fine.
Thanks, Alexander
On 4/29/20 7:31 AM, Andy Herrick wrote:
Please review fix at [1] for issue [2]
The change just adds error when specified icon is not found, and a test for that.
/Andy
[1] - http://cr.openjdk.java.net/~herrick/8244018/webrev.01/
participants (2)
-
Alexander Matveev
-
Andy Herrick