RFR (JAXP) JDK-8156513: Problem list javax/xml/jaxp/unittest/stream/FactoryFindTest.java
javax/xml/jaxp/unittest/stream/FactoryFindTest.java This jaxp test creates and may left over file under testing jdk (jdk/lib/stax.properties) and other tests being affected. (JDK-8156508) This patch is to add this test to ProblemList.txt until mentioned issue resolved. bug: https://bugs.openjdk.java.net/browse/JDK-8156513 webrev: http://cr.openjdk.java.net/~amlu/8156513/webrev.00/ Thanks, Amy --- old/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 +++ new/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 @@ -29,3 +29,5 @@ # 8150145 javax/xml/jaxp/unittest/common/TransformationWarningsTest.java generic-all +# 8156508 +javax/xml/jaxp/unittest/stream/FactoryFindTest.java generic-all
Hi Amy, Looks fine to add to the problem list. It looks like that ProblemList.txt has not been converted to use the new format with the bug number as the second field. Roger On 5/9/2016 1:14 AM, Amy Lu wrote:
javax/xml/jaxp/unittest/stream/FactoryFindTest.java
This jaxp test creates and may left over file under testing jdk (jdk/lib/stax.properties) and other tests being affected. (JDK-8156508) This patch is to add this test to ProblemList.txt until mentioned issue resolved.
bug: https://bugs.openjdk.java.net/browse/JDK-8156513 webrev: http://cr.openjdk.java.net/~amlu/8156513/webrev.00/
Thanks, Amy
--- old/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 +++ new/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 @@ -29,3 +29,5 @@ # 8150145 javax/xml/jaxp/unittest/common/TransformationWarningsTest.java generic-all
+# 8156508 +javax/xml/jaxp/unittest/stream/FactoryFindTest.java generic-all
I assume this is an intermittent failure. It looks like the newly added module tests were interfering with this test. -Joe On 5/9/2016 8:46 AM, Roger Riggs wrote:
Hi Amy,
Looks fine to add to the problem list.
It looks like that ProblemList.txt has not been converted to use the new format with the bug number as the second field.
Roger
On 5/9/2016 1:14 AM, Amy Lu wrote:
javax/xml/jaxp/unittest/stream/FactoryFindTest.java
This jaxp test creates and may left over file under testing jdk (jdk/lib/stax.properties) and other tests being affected. (JDK-8156508) This patch is to add this test to ProblemList.txt until mentioned issue resolved.
bug: https://bugs.openjdk.java.net/browse/JDK-8156513 webrev: http://cr.openjdk.java.net/~amlu/8156513/webrev.00/
Thanks, Amy
--- old/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 +++ new/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 @@ -29,3 +29,5 @@ # 8150145 javax/xml/jaxp/unittest/common/TransformationWarningsTest.java generic-all
+# 8156508 +javax/xml/jaxp/unittest/stream/FactoryFindTest.java generic-all
On 5/10/16 6:36 AM, huizhe wang wrote:
I assume this is an intermittent failure. It looks like the newly added module tests were interfering with this test. Hi, Joe
If jdk/lib/stax.properties exist (created by FactoryFindTest.java), BasicModularXMLParserTest.java and LayerModularXMLParserTest.java will fail (reproducible). FactoryFindTest.java changes the "jdk" under testing, this is in question. If it have to do that, maybe could do change on a copy and testing the copied jdk. Or, at least, it should make sure to clean up the change. Thanks, Amy
-Joe
On 5/9/2016 8:46 AM, Roger Riggs wrote:
Hi Amy,
Looks fine to add to the problem list.
It looks like that ProblemList.txt has not been converted to use the new format with the bug number as the second field.
Roger
On 5/9/2016 1:14 AM, Amy Lu wrote:
javax/xml/jaxp/unittest/stream/FactoryFindTest.java
This jaxp test creates and may left over file under testing jdk (jdk/lib/stax.properties) and other tests being affected. (JDK-8156508) This patch is to add this test to ProblemList.txt until mentioned issue resolved.
bug: https://bugs.openjdk.java.net/browse/JDK-8156513 webrev: http://cr.openjdk.java.net/~amlu/8156513/webrev.00/
Thanks, Amy
--- old/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 +++ new/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 @@ -29,3 +29,5 @@ # 8150145 javax/xml/jaxp/unittest/common/TransformationWarningsTest.java generic-all
+# 8156508 +javax/xml/jaxp/unittest/stream/FactoryFindTest.java generic-all
On 5/9/2016 7:16 PM, Amy Lu wrote:
On 5/10/16 6:36 AM, huizhe wang wrote:
I assume this is an intermittent failure. It looks like the newly added module tests were interfering with this test. Hi, Joe
If jdk/lib/stax.properties exist (created by FactoryFindTest.java), BasicModularXMLParserTest.java and LayerModularXMLParserTest.java will fail (reproducible).
FactoryFindTest.java changes the "jdk" under testing, this is in question. If it have to do that, maybe could do change on a copy and testing the copied jdk. Or, at least, it should make sure to clean up the change.
FactoryFindTest wasn't thread safe. It was fine / it would have removed the properties file before the module tests were added. I haven't observed such failures locally, or in JPRT testing, that's why I was saying this is intermittent. I suspect the module tests were trying to read the file, which prevented FactoryFindTest from deleting it. You may modify FactoryFindTest so that it runs in an isolated JDK, unfortunately, that had issue as well (JDK-8147431). The other option is to disable the particular test case within FactoryFindTest that generated the file and leave it to the JCK. Thanks, Joe
Thanks, Amy
-Joe
On 5/9/2016 8:46 AM, Roger Riggs wrote:
Hi Amy,
Looks fine to add to the problem list.
It looks like that ProblemList.txt has not been converted to use the new format with the bug number as the second field.
Roger
On 5/9/2016 1:14 AM, Amy Lu wrote:
javax/xml/jaxp/unittest/stream/FactoryFindTest.java
This jaxp test creates and may left over file under testing jdk (jdk/lib/stax.properties) and other tests being affected. (JDK-8156508) This patch is to add this test to ProblemList.txt until mentioned issue resolved.
bug: https://bugs.openjdk.java.net/browse/JDK-8156513 webrev: http://cr.openjdk.java.net/~amlu/8156513/webrev.00/
Thanks, Amy
--- old/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 +++ new/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 @@ -29,3 +29,5 @@ # 8150145 javax/xml/jaxp/unittest/common/TransformationWarningsTest.java generic-all
+# 8156508 +javax/xml/jaxp/unittest/stream/FactoryFindTest.java generic-all
On 5/10/16 12:31 PM, huizhe wang wrote:
On 5/9/2016 7:16 PM, Amy Lu wrote:
On 5/10/16 6:36 AM, huizhe wang wrote:
I assume this is an intermittent failure. It looks like the newly added module tests were interfering with this test. Hi, Joe
If jdk/lib/stax.properties exist (created by FactoryFindTest.java), BasicModularXMLParserTest.java and LayerModularXMLParserTest.java will fail (reproducible).
FactoryFindTest.java changes the "jdk" under testing, this is in question. If it have to do that, maybe could do change on a copy and testing the copied jdk. Or, at least, it should make sure to clean up the change.
FactoryFindTest wasn't thread safe. It was fine / it would have removed the properties file before the module tests were added. I haven't observed such failures locally, or in JPRT testing, that's why I was saying this is intermittent. I suspect the module tests were trying to read the file, which prevented FactoryFindTest from deleting it.
You may modify FactoryFindTest so that it runs in an isolated JDK, unfortunately, that had issue as well (JDK-8147431). The other option is to disable the particular test case within FactoryFindTest that generated the file and leave it to the JCK.
Thanks, Joe Thank you Joe! I added this to JDK-8156508 comment as suggestion on the fix.
Thanks, Amy
On 5/9/16 11:46 PM, Roger Riggs wrote:
Hi Amy,
Looks fine to add to the problem list.
It looks like that ProblemList.txt has not been converted to use the new format with the bug number as the second field. Yes, noticed. I created RFE JDK-8156598 to track the format change.
Thank you for reviewing. Thanks, Amy
Roger
On 5/9/2016 1:14 AM, Amy Lu wrote:
javax/xml/jaxp/unittest/stream/FactoryFindTest.java
This jaxp test creates and may left over file under testing jdk (jdk/lib/stax.properties) and other tests being affected. (JDK-8156508) This patch is to add this test to ProblemList.txt until mentioned issue resolved.
bug: https://bugs.openjdk.java.net/browse/JDK-8156513 webrev: http://cr.openjdk.java.net/~amlu/8156513/webrev.00/
Thanks, Amy
--- old/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 +++ new/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 @@ -29,3 +29,5 @@ # 8150145 javax/xml/jaxp/unittest/common/TransformationWarningsTest.java generic-all
+# 8156508 +javax/xml/jaxp/unittest/stream/FactoryFindTest.java generic-all
participants (3)
-
Amy Lu
-
huizhe wang
-
Roger Riggs