RFR: 8231490: Ugly racy writes to ZipUtils.defaultBuf
This change applies the minimal fix suggested in https://bugs.openjdk.java.net/browse/JDK-8231490. The bug text suggests possibilities for reworking, but notes that this change is enough to fix the data race. Adding a regression test is probaby not feasible but we do observe that Java TSAN no longer reports a race after the change. ------------- Commit messages: - 8231490: Fix a data race in java.util.zip.Inflater Changes: https://git.openjdk.java.net/jdk/pull/6242/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6242&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8231490 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/6242.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6242/head:pull/6242 PR: https://git.openjdk.java.net/jdk/pull/6242
On Wed, 3 Nov 2021 21:46:08 GMT, Eamonn McManus <emcmanus@openjdk.org> wrote:
This change applies the minimal fix suggested in https://bugs.openjdk.java.net/browse/JDK-8231490. The bug text suggests possibilities for reworking, but notes that this change is enough to fix the data race. Adding a regression test is probaby not feasible but we do observe that Java TSAN no longer reports a race after the change.
This change seems OK. I ran mach5 tiers 1-3 and all are clean as well ------------- PR: https://git.openjdk.java.net/jdk/pull/6242
On Wed, 3 Nov 2021 21:46:08 GMT, Eamonn McManus <emcmanus@openjdk.org> wrote:
This change applies the minimal fix suggested in https://bugs.openjdk.java.net/browse/JDK-8231490. The bug text suggests possibilities for reworking, but notes that this change is enough to fix the data race. Adding a regression test is probaby not feasible but we do observe that Java TSAN no longer reports a race after the change.
Looks like I forgot to hit approve with my earlier comment ------------- Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6242
On Wed, 3 Nov 2021 21:46:08 GMT, Eamonn McManus <emcmanus@openjdk.org> wrote:
This change applies the minimal fix suggested in https://bugs.openjdk.java.net/browse/JDK-8231490. The bug text suggests possibilities for reworking, but notes that this change is enough to fix the data race. Adding a regression test is probaby not feasible but we do observe that Java TSAN no longer reports a race after the change.
This pull request has now been integrated. Changeset: 905e3e88 Author: Eamonn McManus <emcmanus@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/905e3e88137d46f90de7034e9fc324e97af8... Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8231490: Ugly racy writes to ZipUtils.defaultBuf Reviewed-by: lancea ------------- PR: https://git.openjdk.java.net/jdk/pull/6242
participants (2)
-
Eamonn McManus
-
Lance Andersen