Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError
I’ve looked at a random sample of these changes and they look ok. Since some of the changes are in non-serviceability code I have also added core-libs to the review thread. I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted. Thanks, /Staffan On 25 mar 2014, at 13:07, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> wrote:
Hi,
Could I please have a review of this fix.
webrev: http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8034960
When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
Verified locally since no JTreg with fix has been promoted yet.
Thanks, Katja
On 25/03/2014 12:14, Staffan Larsen wrote:
I’ve looked at a random sample of these changes and they look ok.
Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
Thanks, /Staffan Katja - the changes look okay but I wonder about tests that didn't previously have @build or @compile tags. Take TestJcmdDefaults as an example, it now has:
@build jdk.testlibrary.* and I just wonder if it should be: @build TestJcmdDefaults jdk.testlibrary.* so that it compiles the test in addition to the test library. This could be a misunderstanding on my part of course, maybe the source file with @test is always compiled if it's a java test? -Alan
On 03/25/2014 02:53 PM, Alan Bateman wrote:
On 25/03/2014 12:14, Staffan Larsen wrote:
I’ve looked at a random sample of these changes and they look ok.
Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
Thanks, /Staffan Katja - the changes look okay but I wonder about tests that didn't previously have @build or @compile tags. Take TestJcmdDefaults as an example, it now has:
@build jdk.testlibrary.*
and I just wonder if it should be:
@build TestJcmdDefaults jdk.testlibrary.*
so that it compiles the test in addition to the test library. This could be a misunderstanding on my part of course, maybe the source file with @test is always compiled if it's a java test?
My assumption is the test itself is always compiled. If it's false, I'm afraid we need to change a bunch of other tests. Jon, could you please explain? // Katja
-Alan
On 03/25/2014 07:31 AM, Yekaterina Kantserova wrote:
On 03/25/2014 02:53 PM, Alan Bateman wrote:
On 25/03/2014 12:14, Staffan Larsen wrote:
I’ve looked at a random sample of these changes and they look ok.
Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
Thanks, /Staffan Katja - the changes look okay but I wonder about tests that didn't previously have @build or @compile tags. Take TestJcmdDefaults as an example, it now has:
@build jdk.testlibrary.*
and I just wonder if it should be:
@build TestJcmdDefaults jdk.testlibrary.*
so that it compiles the test in addition to the test library. This could be a misunderstanding on my part of course, maybe the source file with @test is always compiled if it's a java test?
My assumption is the test itself is always compiled. If it's false, I'm afraid we need to change a bunch of other tests.
Jon, could you please explain?
// Katja
-Alan
There is no such thing as "the source file with @test". Those words don't make sense. The class specified in an "@run main" directive is subject to an implicit "@build" meaning that it will be compiled if needed. -- Jon
On 03/25/2014 01:14 PM, Staffan Larsen wrote:
I’ve looked at a random sample of these changes and they look ok.
Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted. I would not. My thought was to be done with review process and be ready to push when JTreg is promoted.
Thank you for adding other groups! Katja
Thanks, /Staffan
On 25 mar 2014, at 13:07, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> wrote:
Hi,
Could I please have a review of this fix.
webrev: http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8034960
When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
Verified locally since no JTreg with fix has been promoted yet.
Thanks, Katja
Hi, The version b09 of JTreg which contains https://bugs.openjdk.java.net/browse/CODETOOLS-7900178 has been promoted. So it seems to be time to push the fix for JDK-8034960. I've made a new webrev to be sure the changes fit in in the latest jdk9 source. The webrev can be found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01. Thanks, Katja On 03/25/2014 01:14 PM, Staffan Larsen wrote:
I’ve looked at a random sample of these changes and they look ok.
Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
Thanks, /Staffan
On 25 mar 2014, at 13:07, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> wrote:
Hi,
Could I please have a review of this fix.
webrev: http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8034960
When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
Verified locally since no JTreg with fix has been promoted yet.
Thanks, Katja
Looks good! Thanks, /Staffan On 9 maj 2014, at 12:43, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> wrote:
Hi,
The version b09 of JTreg which contains https://bugs.openjdk.java.net/browse/CODETOOLS-7900178 has been promoted. So it seems to be time to push the fix for JDK-8034960. I've made a new webrev to be sure the changes fit in in the latest jdk9 source. The webrev can be found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01.
Thanks, Katja
On 03/25/2014 01:14 PM, Staffan Larsen wrote:
I’ve looked at a random sample of these changes and they look ok.
Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
Thanks, /Staffan
On 25 mar 2014, at 13:07, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> wrote:
Hi,
Could I please have a review of this fix.
webrev: http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8034960
When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
Verified locally since no JTreg with fix has been promoted yet.
Thanks, Katja
Staffan, could you please be my sponsor and push this fix? I have discovered three more tests that should bechanged: sun/management/jmxremote/bootstrap/CustomLauncherTest.java java/lang/management/MemoryMXBean/CollectionUsageThreshold.java java/lang/management/MemoryMXBean/LowMemoryTest.java The webrev that includes them can be found here: http://cr.openjdk.java.net/~ykantser/8034960/webrev.02/ Thanks, Katja -------- Original Message -------- Subject: Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError Date: Fri, 9 May 2014 12:48:56 +0200 From: Staffan Larsen <staffan.larsen@oracle.com> To: Yekaterina Kantserova <yekaterina.kantserova@oracle.com> CC: Alan Bateman <Alan.Bateman@oracle.com>, "serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net" <serviceability-dev@openjdk.java.net>, core-libs-dev Libs <core-libs-dev@openjdk.java.net> Looks good! Thanks, /Staffan On 9 maj 2014, at 12:43, Yekaterina Kantserova<yekaterina.kantserova@oracle.com> wrote:
Hi,
The version b09 of JTreg which containshttps://bugs.openjdk.java.net/browse/CODETOOLS-7900178 has been promoted. So it seems to be time to push the fix for JDK-8034960. I've made a new webrev to be sure the changes fit in in the latest jdk9 source. The webrev can be found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01.
Thanks, Katja
On 03/25/2014 01:14 PM, Staffan Larsen wrote:
I’ve looked at a random sample of these changes and they look ok.
Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
Thanks, /Staffan
On 25 mar 2014, at 13:07, Yekaterina Kantserova<yekaterina.kantserova@oracle.com> wrote:
Hi,
Could I please have a review of this fix.
webrev:http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/ bug:https://bugs.openjdk.java.net/browse/JDK-8034960
When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
Verified locally since no JTreg with fix has been promoted yet.
Thanks, Katja
Pushed: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/05e9c9216e26 Thanks, /Staffan On 12 maj 2014, at 10:28, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> wrote:
Staffan,
could you please be my sponsor and push this fix?
I have discovered three more tests that should be changed: sun/management/jmxremote/bootstrap/CustomLauncherTest.java java/lang/management/MemoryMXBean/CollectionUsageThreshold.java java/lang/management/MemoryMXBean/LowMemoryTest.java
The webrev that includes them can be found here: http://cr.openjdk.java.net/~ykantser/8034960/webrev.02/
Thanks, Katja
-------- Original Message -------- Subject: Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError Date: Fri, 9 May 2014 12:48:56 +0200 From: Staffan Larsen <staffan.larsen@oracle.com> To: Yekaterina Kantserova <yekaterina.kantserova@oracle.com> CC: Alan Bateman <Alan.Bateman@oracle.com>, "serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net" <serviceability-dev@openjdk.java.net>, core-libs-dev Libs <core-libs-dev@openjdk.java.net>
Looks good!
Thanks, /Staffan
On 9 maj 2014, at 12:43, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> wrote:
Hi,
The version b09 of JTreg which contains https://bugs.openjdk.java.net/browse/CODETOOLS-7900178 has been promoted. So it seems to be time to push the fix for JDK-8034960. I've made a new webrev to be sure the changes fit in in the latest jdk9 source. The webrev can be found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01.
Thanks, Katja
On 03/25/2014 01:14 PM, Staffan Larsen wrote:
I’ve looked at a random sample of these changes and they look ok.
Since some of the changes are in non-serviceability code I have also added core-libs to the review thread.
I’m sure you know this, but for the record: please don’t push this until jtreg with the fix has been promoted.
Thanks, /Staffan
On 25 mar 2014, at 13:07, Yekaterina Kantserova <yekaterina.kantserova@oracle.com> wrote:
Hi,
Could I please have a review of this fix.
webrev: http://cr.openjdk.java.net/~ykantser/8034960/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8034960
When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
Verified locally since no JTreg with fix has been promoted yet.
Thanks, Katja
<8034960.open.patch>
On 09/05/2014 11:43, Yekaterina Kantserova wrote:
Hi,
The version b09 of JTreg which contains https://bugs.openjdk.java.net/browse/CODETOOLS-7900178 has been promoted. So it seems to be time to push the fix for JDK-8034960. I've made a new webrev to be sure the changes fit in in the latest jdk9 source. The webrev can be found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01. Thanks for doing this, it should make concurrent test runs a lot more stable. I've skimmed over the changes and they look good to me too.
-Alan
Staffan, Alan, thanks for reviews! I will wait with pushing it until Monday to make sure no one has objections. // Katja On 05/09/2014 01:07 PM, Alan Bateman wrote:
On 09/05/2014 11:43, Yekaterina Kantserova wrote:
Hi,
The version b09 of JTreg which contains https://bugs.openjdk.java.net/browse/CODETOOLS-7900178 has been promoted. So it seems to be time to push the fix for JDK-8034960. I've made a new webrev to be sure the changes fit in in the latest jdk9 source. The webrev can be found here: cr.openjdk.java.net/~ykantser/8034960/webrev.01. Thanks for doing this, it should make concurrent test runs a lot more stable. I've skimmed over the changes and they look good to me too.
-Alan
participants (4)
-
Alan Bateman
-
Jonathan Gibbons
-
Staffan Larsen
-
Yekaterina Kantserova