Hi Vipin, Looks fine. I see you filed separate tasks for the other packages in java.rmi. [1] That's unnecessarily fine grained. It would be more efficient to do them all in one code review, saving your time and reviewers time. Also, I noticed that those files still use the <code> </code> markup. Converting them to use {@code ... } is another useful task. Thanks, Roger [1]https://bugs.openjdk.java.net/browse/JDK-8252536 On 9/2/20 12:18 PM, Vipin Sharma wrote:

Hi Roger,

On Tue, Sep 1, 2020 at 10:49 PM Roger Riggs <Roger.Riggs@oracle.com <mailto:Roger.Riggs@oracle.com>> wrote:

Hi Vipin,

Looks fine.

Though I would also correct the indentation and join source lines in a few cases.

MasrshalledObject.java.  Continuation lines should be indented. Lines 110 and 164, 166.

Fixed.

Naming.java: Join line 110, 137, 162, 191: "appropriately... formatted URL"

Fixed lines 113, 140, and 164 as well, similar problems.

Thanks, Roger

Updated webrev: https://cr.openjdk.java.net/~vsharma/8252538/webrev.02/

Regards, Vipin

On 3 Sep 2020, at 18:51, Vipin Sharma <vipinsharma85@gmail.com> wrote:

I agree. In the next patch, I will include all remaining occurrences of @exception in the core-libs <https://openjdk.java.net/groups/core-libs/> area.

Also, I noticed that those files still use the <code> </code> markup.

...

Converting them to use {@code ... } is another useful task.

I will take this task.

Please be careful and always build documentation to check that it looks the way you think it looks. -Pavel