[jdk17] RFR: JDK-8270872: Final nroff manpage update for JDK 17
Please review a semi-automatic update of the nroff man pages from the upstream files. ------------- Commit messages: - JDK-8270872: Final nroff manpage update for JDK 17 Changes: https://git.openjdk.java.net/jdk17/pull/303/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=303&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270872 Stats: 289 lines in 27 files changed: 117 ins; 31 del; 141 mod Patch: https://git.openjdk.java.net/jdk17/pull/303.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/303/head:pull/303 PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:
Please review a semi-automatic update of the nroff man pages from the upstream files.
Marked as reviewed by darcy (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:
Please review a semi-automatic update of the nroff man pages from the upstream files.
src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
This seems not correct? ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:57:59 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Please review a semi-automatic update of the nroff man pages from the upstream files.
src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
This seems not correct?
According to the comments in the makefile (`closed/make/UpdateOpenManPages.gmk`) the copyright line is taken from the original Markdown file, so if the year is wrong there, it will be wrong in the generated nroff file. I think it would be incorrect to edit the dates locally in these files, because they'll just be overwritten when we generate the files again. Ideally, the dates should be fixed (if necessary) in the Markdown files, but that seems out of scope for this P1. This is "just" an issue with copyright dates in source files ... and yes, while I know copyright dates are important, this problem is arguably part of an ongoing more general problem. I note that the generated files *do* correctly identify themselves with `2021` in the visible output generated to the console by the `man` command. ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 21:36:58 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:
src/jdk.hotspot.agent/share/man/jhsdb.1 line 1:
1: .\" Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
This seems not correct?
According to the comments in the makefile (`closed/make/UpdateOpenManPages.gmk`) the copyright line is taken from the original Markdown file, so if the year is wrong there, it will be wrong in the generated nroff file.
I think it would be incorrect to edit the dates locally in these files, because they'll just be overwritten when we generate the files again. Ideally, the dates should be fixed (if necessary) in the Markdown files, but that seems out of scope for this P1.
This is "just" an issue with copyright dates in source files ... and yes, while I know copyright dates are important, this problem is arguably part of an ongoing more general problem.
I note that the generated files *do* correctly identify themselves with `2021` in the visible output generated to the console by the `man` command.
Thanks for the explanation, Jon. Fine by me. ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 21:40:40 GMT, Naoto Sato <naoto@openjdk.org> wrote:
According to the comments in the makefile (`closed/make/UpdateOpenManPages.gmk`) the copyright line is taken from the original Markdown file, so if the year is wrong there, it will be wrong in the generated nroff file.
I think it would be incorrect to edit the dates locally in these files, because they'll just be overwritten when we generate the files again. Ideally, the dates should be fixed (if necessary) in the Markdown files, but that seems out of scope for this P1.
This is "just" an issue with copyright dates in source files ... and yes, while I know copyright dates are important, this problem is arguably part of an ongoing more general problem.
I note that the generated files *do* correctly identify themselves with `2021` in the visible output generated to the console by the `man` command.
Thanks for the explanation, Jon. Fine by me.
I agree that fixing this date is not necessary at this time. ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:
Please review a semi-automatic update of the nroff man pages from the upstream files.
Marked as reviewed by mr (Lead). ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:
Please review a semi-automatic update of the nroff man pages from the upstream files.
Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:
Please review a semi-automatic update of the nroff man pages from the upstream files.
Marked as reviewed by naoto (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
On Thu, 5 Aug 2021 19:20:50 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:
Please review a semi-automatic update of the nroff man pages from the upstream files.
This pull request has now been integrated. Changeset: dfacda48 Author: Jonathan Gibbons <jjg@openjdk.org> URL: https://git.openjdk.java.net/jdk17/commit/dfacda488bfbe2e11e8d607a6d08527710... Stats: 289 lines in 27 files changed: 117 ins; 31 del; 141 mod 8270872: Final nroff manpage update for JDK 17 Reviewed-by: darcy, mr, iris, naoto ------------- PR: https://git.openjdk.java.net/jdk17/pull/303
participants (5)
-
Iris Clark
-
Joe Darcy
-
Jonathan Gibbons
-
Mark Reinhold
-
Naoto Sato