RFR: 8378354: Faulty assertion in checkInvariants method of ConcurrentHashMap
Raise a new PR. for https://github.com/openjdk/jdk/pull/24612 is too old. "In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red." ------------- Commit messages: - Fix red-black tree invariant check in ConcurrentHashMap Changes: https://git.openjdk.org/jdk/pull/29857/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29857&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8378354 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/29857.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29857/head:pull/29857 PR: https://git.openjdk.org/jdk/pull/29857
On Sat, 21 Feb 2026 16:51:17 GMT, cdw200806 <duke@openjdk.org> wrote:
Raise a new PR. for https://github.com/openjdk/jdk/pull/24612 is too old.
"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."
Marked as reviewed by alanb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29857#pullrequestreview-3835741973
On Sat, 21 Feb 2026 16:51:17 GMT, cdw200806 <duke@openjdk.org> wrote:
Raise a new PR. for https://github.com/openjdk/jdk/pull/24612 is too old.
"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."
Thanks for the discovery and fix. ------------- Marked as reviewed by vklang (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29857#pullrequestreview-3837949299
On Sat, 21 Feb 2026 16:51:17 GMT, cdw200806 <duke@openjdk.org> wrote:
Raise a new PR. for https://github.com/openjdk/jdk/pull/24612 is too old.
"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."
@cdw200806 You need to add a comment with "/integrate" so it can be sponsored. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29857#issuecomment-3949752749
On Tue, 24 Feb 2026 07:25:55 GMT, Alan Bateman <alanb@openjdk.org> wrote:
@cdw200806 You need to add a comment with "/integrate" so it can be sponsored.
Hi @AlanBateman , thanks for your reminding, now it is ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29857#issuecomment-3950252160
On Sat, 21 Feb 2026 16:51:17 GMT, cdw200806 <duke@openjdk.org> wrote:
Raise a new PR. for https://github.com/openjdk/jdk/pull/24612 is too old.
"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."
@cdw200806 Your change (at version 378c31e9c525e30f4dff008a9d3fbcfe64668081) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29857#issuecomment-3950200335
On Sat, 21 Feb 2026 16:51:17 GMT, cdw200806 <duke@openjdk.org> wrote:
Raise a new PR. for https://github.com/openjdk/jdk/pull/24612 is too old.
"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."
This pull request has now been integrated. Changeset: b99d1f0a Author: cdw200806 <56459974+cdw200806@users.noreply.github.com> Committer: Viktor Klang <vklang@openjdk.org> URL: https://git.openjdk.org/jdk/commit/b99d1f0a1723261718d68ffafbdb9efb315ccfc7 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8378354: Faulty assertion in checkInvariants method of ConcurrentHashMap Reviewed-by: alanb, vklang ------------- PR: https://git.openjdk.org/jdk/pull/29857
participants (4)
-
Alan Bateman
-
cdw200806
-
duke
-
Viktor Klang