RFR: 8261621: Delegate Unicode history from JLS to j.l.Character
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly. ------------- Commit messages: - 8261621: Delegate Unicode history from JLS to j.l.Character Changes: https://git.openjdk.java.net/jdk/pull/2538/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2538&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261621 Stats: 37 lines in 1 file changed: 35 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2538.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2538/head:pull/2538 PR: https://git.openjdk.java.net/jdk/pull/2538
On Fri, 12 Feb 2021 02:50:35 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Looks fine to me. ------------- Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2538
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Removed empty <p> tag ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2538/files - new: https://git.openjdk.java.net/jdk/pull/2538/files/5560a4cf..b026b5eb Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2538&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2538&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2538.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2538/head:pull/2538 PR: https://git.openjdk.java.net/jdk/pull/2538
On Fri, 12 Feb 2021 04:06:55 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
Removed empty <p> tag
Marked as reviewed by joehw (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
On Fri, 12 Feb 2021 04:06:55 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
Removed empty <p> tag
The table is informative and should not be construed as specification. The wording "has supported" should be sufficient. ------------- Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2538
On Fri, 12 Feb 2021 15:22:15 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The table is informative and should not be construed as specification. The wording "has supported" should be sufficient.
If this is not specification then doesn't that imply that any provider of any version of OpenJDK would be free to support, or not, whatever version of Unicode that they chose? Surely a minimum supported version must be part of the platform specification? ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
On Thu, 18 Feb 2021 03:56:49 GMT, David Holmes <dholmes@openjdk.org> wrote:
The table is informative and should not be construed as specification. The wording "has supported" should be sufficient.
The table is informative and should not be construed as specification. The wording "has supported" should be sufficient.
If this is not specification then doesn't that imply that any provider of any version of OpenJDK would be free to support, or not, whatever version of Unicode that they chose? Surely a minimum supported version must be part of the platform specification?
The current version of Unicode is specified in a normative statement just before the table. "Character information is based on the Unicode Standard, version 13.0." The table is not a specification of past revisions. ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
On Thu, 18 Feb 2021 14:49:20 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The table is informative and should not be construed as specification. The wording "has supported" should be sufficient.
If this is not specification then doesn't that imply that any provider of any version of OpenJDK would be free to support, or not, whatever version of Unicode that they chose? Surely a minimum supported version must be part of the platform specification?
The current version of Unicode is specified in a normative statement just before the table. "Character information is based on the Unicode Standard, version 13.0."
The table is not a specification of past revisions.
RIght. And each Java SE release's spec has the same sentence with the version replaced. In fact, vendors cannot incorporate arbitrary Unicode versions as it would involve API changes. If they wanted to do so, an MR should have to be released. ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
On 20/02/2021 12:00 am, Naoto Sato wrote:
On Thu, 18 Feb 2021 14:49:20 GMT, Roger Riggs <rriggs@openjdk.org> wrote:
The table is informative and should not be construed as specification. The wording "has supported" should be sufficient.
If this is not specification then doesn't that imply that any provider of any version of OpenJDK would be free to support, or not, whatever version of Unicode that they chose? Surely a minimum supported version must be part of the platform specification?
The current version of Unicode is specified in a normative statement just before the table. "Character information is based on the Unicode Standard, version 13.0."
The table is not a specification of past revisions.
RIght. And each Java SE release's spec has the same sentence with the version replaced. In fact, vendors cannot incorporate arbitrary Unicode versions as it would involve API changes. If they wanted to do so, an MR should have to be released.
Roger and Naoto, thanks for clarifying. I took Roger's original comment out of context. David
-------------
On Fri, 12 Feb 2021 04:06:55 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
Removed empty <p> tag
src/java.base/share/classes/java/lang/Character.java line 86:
84: * <td>Unicode 10.0</td></tr> 85: * <tr><td>Java SE 9</td> 86: * <td>Unicode 8.0</td></tr>
Do we really need the history in the API docs? Will will update this table if there is a MR of the JSR for Java 8 that moves to a new Unicode release? ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
On Fri, 12 Feb 2021 16:13:04 GMT, Alan Bateman <alanb@openjdk.org> wrote:
Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
Removed empty <p> tag
src/java.base/share/classes/java/lang/Character.java line 86:
84: * <td>Unicode 10.0</td></tr> 85: * <tr><td>Java SE 9</td> 86: * <td>Unicode 8.0</td></tr>
Do we really need the history in the API docs? Will will update this table if there is a MR of the JSR for Java 8 that moves to a new Unicode release?
This was requested by Alex, and I thought it sounded reasonable and informative. I think if an MR upgrades the supported Unicode version, it should be listed here. ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
On Fri, 12 Feb 2021 17:03:57 GMT, Naoto Sato <naoto@openjdk.org> wrote:
src/java.base/share/classes/java/lang/Character.java line 86:
84: * <td>Unicode 10.0</td></tr> 85: * <tr><td>Java SE 9</td> 86: * <td>Unicode 8.0</td></tr>
Do we really need the history in the API docs? Will will update this table if there is a MR of the JSR for Java 8 that moves to a new Unicode release?
This was requested by Alex, and I thought it sounded reasonable and informative. I think if an MR upgrades the supported Unicode version, it should be listed here.
Should some acknowledgement be made to the changes in Unicode support done by the Java SE 8 and Java SE 11 MRs with respect to extensions of the base Unicode version? ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
On Fri, 12 Feb 2021 20:29:28 GMT, Joe Darcy <darcy@openjdk.org> wrote:
This was requested by Alex, and I thought it sounded reasonable and informative. I think if an MR upgrades the supported Unicode version, it should be listed here.
Should some acknowledgement be made to the changes in Unicode support done by the Java SE 8 and Java SE 11 MRs with respect to extensions of the base Unicode version?
I thought about that but decided not to include them here because the changes made in those MRs were not Unicode version upgrades (i.e., version stayed the same). Let me know if you think otherwise. ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Removed empty <p> tag - 8261621: Delegate Unicode history from JLS to j.l.Character ------------- Changes: https://git.openjdk.java.net/jdk/pull/2538/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2538&range=02 Stats: 36 lines in 1 file changed: 34 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2538.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2538/head:pull/2538 PR: https://git.openjdk.java.net/jdk/pull/2538
On Tue, 16 Feb 2021 17:59:51 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Removed empty <p> tag - 8261621: Delegate Unicode history from JLS to j.l.Character
Marked as reviewed by rriggs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Added a text about the variations from the base Unicode versions. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2538/files - new: https://git.openjdk.java.net/jdk/pull/2538/files/b94b41c8..c90cd663 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2538&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2538&range=02-03 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2538.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2538/head:pull/2538 PR: https://git.openjdk.java.net/jdk/pull/2538
On Wed, 17 Feb 2021 17:39:00 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
Added a text about the variations from the base Unicode versions.
Marked as reviewed by darcy (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
On Fri, 12 Feb 2021 02:50:35 GMT, Naoto Sato <naoto@openjdk.org> wrote:
Please review this doc fix to j.l.Character, which now includes the table of the history of supported Unicode versions. A corresponding CSR will be filed accordingly.
This pull request has now been integrated. Changeset: ea5bf45c Author: Naoto Sato <naoto@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/ea5bf45c Stats: 38 lines in 1 file changed: 36 ins; 0 del; 2 mod 8261621: Delegate Unicode history from JLS to j.l.Character Reviewed-by: bpb, joehw, rriggs, darcy ------------- PR: https://git.openjdk.java.net/jdk/pull/2538
participants (8)
-
Alan Bateman
-
Brian Burkhalter
-
David Holmes
-
David Holmes
-
Joe Darcy
-
Joe Wang
-
Naoto Sato
-
Roger Riggs