RFR: JDK-8272639: jpackaged applications using microphone on mac
JDK-8272639: jpackaged applications using microphone on mac ------------- Commit messages: - JDK-8272639: jpackaged applications using microphone on mac Changes: https://git.openjdk.java.net/jdk/pull/5186/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5186&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8272639 Stats: 5 lines in 3 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5186.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5186/head:pull/5186 PR: https://git.openjdk.java.net/jdk/pull/5186
On Thu, 19 Aug 2021 14:12:00 GMT, Andy Herrick <herrick@openjdk.org> wrote:
JDK-8272639: jpackaged applications using microphone on mac
Marked as reviewed by almatvee (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/5186
On Thu, 19 Aug 2021 14:12:00 GMT, Andy Herrick <herrick@openjdk.org> wrote:
JDK-8272639: jpackaged applications using microphone on mac
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/Info-lite.plist.template line 37:
35: <string>true</string> 36: <key>NSMicrophoneUsageDescription</key> 37: <string>The application is requesting access to the microphone.</string>
Should not it include the "application name" here? This is different from the java tool, where we do not know that info in advance. ------------- PR: https://git.openjdk.java.net/jdk/pull/5186
On Thu, 19 Aug 2021 22:46:18 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:
JDK-8272639: jpackaged applications using microphone on mac
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/Info-lite.plist.template line 37:
35: <string>true</string> 36: <key>NSMicrophoneUsageDescription</key> 37: <string>The application is requesting access to the microphone.</string>
Should not it include the "application name" here? This is different from the java tool, where we do not know that info in advance.
Yes - I will revise with name substituted here. I also considered localizing this string, but we only support localization of the tool, which would put string in the local that jpackage was run in, not the local the generated artifact was run in. ------------- PR: https://git.openjdk.java.net/jdk/pull/5186
JDK-8272639: jpackaged applications using microphone on mac
Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8272639: jpackaged applications using microphone on mac ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/5186/files - new: https://git.openjdk.java.net/jdk/pull/5186/files/e1f460e1..337e1fa1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5186&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5186&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5186.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5186/head:pull/5186 PR: https://git.openjdk.java.net/jdk/pull/5186
On Mon, 23 Aug 2021 14:34:52 GMT, Andy Herrick <herrick@openjdk.org> wrote:
JDK-8272639: jpackaged applications using microphone on mac
Andy Herrick has updated the pull request incrementally with one additional commit since the last revision:
JDK-8272639: jpackaged applications using microphone on mac
Marked as reviewed by serb (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/5186
On Thu, 19 Aug 2021 14:12:00 GMT, Andy Herrick <herrick@openjdk.org> wrote:
JDK-8272639: jpackaged applications using microphone on mac
This pull request has now been integrated. Changeset: b17b821a Author: Andy Herrick <herrick@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/b17b821a570930e4188bcdfb396f0a7abe99... Stats: 5 lines in 3 files changed: 4 ins; 0 del; 1 mod 8272639: jpackaged applications using microphone on mac Reviewed-by: almatvee, serb ------------- PR: https://git.openjdk.java.net/jdk/pull/5186
participants (3)
-
Alexander Matveev
-
Andy Herrick
-
Sergey Bylokhov