RFR: 8200129 : Remove D3D Performance Counter.
bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/ It was noted in another thread [1] that we had a couple of qualified exports from java.base to java.desktop that are platform-specific but are in the main module-info.java. It was suggested to move these to platform-specific locations. But one of them doesn't seem to be at all important and we can just remove it. It is a "counter" that basically tells you if D3D was used but I don't see any standard tools that support it and I was able to build + run just fine. The other platform-specific export is moved here as suggested since it can't be just removed without some alternative. NB I did build all platforms. -phil. [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-March/052198.html
Looks fine. On 22/03/2018 13:33, Phil Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/
It was noted in another thread [1] that we had a couple of qualified exports from java.base to java.desktop that are platform-specific but are in the main module-info.java.
It was suggested to move these to platform-specific locations. But one of them doesn't seem to be at all important and we can just remove it. It is a "counter" that basically tells you if D3D was used but I don't see any standard tools that support it and I was able to build + run just fine.
The other platform-specific export is moved here as suggested since it can't be just removed without some alternative.
NB I did build all platforms.
-phil.
[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-March/052198.html
-- Best regards, Sergey.
On 22/03/2018 20:33, Phil Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/
This looks okay to me. -Alan
+1 Mandy On 3/22/18 1:33 PM, Phil Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8200129 webrev: http://cr.openjdk.java.net/~prr/8200129/
It was noted in another thread [1] that we had a couple of qualified exports from java.base to java.desktop that are platform-specific but are in the main module-info.java.
It was suggested to move these to platform-specific locations. But one of them doesn't seem to be at all important and we can just remove it. It is a "counter" that basically tells you if D3D was used but I don't see any standard tools that support it and I was able to build + run just fine.
The other platform-specific export is moved here as suggested since it can't be just removed without some alternative.
NB I did build all platforms.
-phil.
[1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-March/052198.html
participants (4)
-
Alan Bateman
-
mandy chung
-
Phil Race
-
Sergey Bylokhov