RFR; 8211031: Remove un-needed qualified export to java.desktop from java.base on macos
Bug: https://bugs.openjdk.java.net/browse/JDK-8211031 webrev: http://cr.openjdk.java.net/~prr/8211031/ Removing some obsolete code which is the reason for a qualified export from java.base to java.desktop. I also cleaned up some commented out debugging code. See the bug evaluation for more details. -phil.
Removal of module-info.java.extra is good. Mandy On 9/21/18 1:13 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8211031 webrev: http://cr.openjdk.java.net/~prr/8211031/
Removing some obsolete code which is the reason for a qualified export from java.base to java.desktop. I also cleaned up some commented out debugging code.
See the bug evaluation for more details.
-phil.
thanks .. I guess you are deferring review of the rest of it to someone from swing. In that Swing area I have a minor update to the fix : http://cr.openjdk.java.net/~prr/8211031.1 [*] since I just realised (meaning just thought to check :-)), that the private method classExists() is called only by the method I have removed .. so classExists() can go too .. -phil. [*] at this exact moment, cr.openjdk.java.net isn't working but hopefully that will be fixed by the time anyone reads this :-) On 9/21/18, 1:45 PM, mandy chung wrote:
Removal of module-info.java.extra is good.
Mandy
On 9/21/18 1:13 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8211031 webrev: http://cr.openjdk.java.net/~prr/8211031/
Removing some obsolete code which is the reason for a qualified export from java.base to java.desktop. I also cleaned up some commented out debugging code.
See the bug evaluation for more details.
-phil.
Hi, Phil. On 21/09/2018 22:24, Philip Race wrote:
[*] at this exact moment, cr.openjdk.java.net isn't working but hopefully that will be fixed by the time anyone reads this :-)
The classExists() method still there in version .1 -- Best regards, Sergey.
Not 100% sure what happened there. I've re-uploaded it. Shift-reload to avoid browser caching and look again. -phil. On 09/26/2018 01:51 PM, Sergey Bylokhov wrote:
Hi, Phil. On 21/09/2018 22:24, Philip Race wrote:
[*] at this exact moment, cr.openjdk.java.net isn't working but hopefully that will be fixed by the time anyone reads this :-)
The classExists() method still there in version .1
Looks fine. On 26/09/2018 14:07, Phil Race wrote:
Not 100% sure what happened there. I've re-uploaded it. Shift-reload to avoid browser caching and look again.
-phil.
On 09/26/2018 01:51 PM, Sergey Bylokhov wrote:
Hi, Phil. On 21/09/2018 22:24, Philip Race wrote:
[*] at this exact moment, cr.openjdk.java.net isn't working but hopefully that will be fixed by the time anyone reads this :-)
The classExists() method still there in version .1
-- Best regards, Sergey.
participants (4)
-
mandy chung
-
Phil Race
-
Philip Race
-
Sergey Bylokhov