On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon <pconcannon@openjdk.org> wrote:

Hi,

Could someone please review my code for updating the code in the `java.util` package to make use of the `instanceof` pattern variable?

Kind regards, Patrick

Changes look good. ------------- Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4088

On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon <pconcannon@openjdk.org> wrote:

Hi,

Could someone please review my code for updating the code in the `java.util` package to make use of the `instanceof` pattern variable?

Kind regards, Patrick

Because we still make jdk11-compatible test-release java.util.concurrent jars, we are not big fans of adding non-essential differences to openjdk version. But if there is some advantage to doing this, we'll cope. ------------- PR: https://git.openjdk.java.net/jdk/pull/4088

Hi,

Could someone please review my code for updating the code in the `java.util` package to make use of the `instanceof` pattern variable?

Kind regards, Patrick

Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - 8267110: Reverted changes in java/util/Formatter as primitive to boxed types may have semantic/performance implications - Merge remote-tracking branch 'origin/master' into JDK-8267110 - 8267110: Update java.util to use instanceof pattern variable ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4088/files - new: https://git.openjdk.java.net/jdk/pull/4088/files/0ed0bd99..cd99dc49 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4088&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4088&range=00-01 Stats: 4003 lines in 175 files changed: 2590 ins; 890 del; 523 mod Patch: https://git.openjdk.java.net/jdk/pull/4088.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4088/head:pull/4088 PR: https://git.openjdk.java.net/jdk/pull/4088

Hi,

Could someone please review my code for updating the code in the `java.util` package to make use of the `instanceof` pattern variable?

Kind regards, Patrick

Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision: 8267110: Reverted changes made to files in java.util.concurrent ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4088/files - new: https://git.openjdk.java.net/jdk/pull/4088/files/da615e7d..2c076a55 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4088&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4088&range=02-03 Stats: 31 lines in 5 files changed: 16 ins; 0 del; 15 mod Patch: https://git.openjdk.java.net/jdk/pull/4088.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4088/head:pull/4088 PR: https://git.openjdk.java.net/jdk/pull/4088

On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon <pconcannon@openjdk.org> wrote:

Hi,

Could someone please review my code for updating the code in the `java.util` package to make use of the `instanceof` pattern variable?

Kind regards, Patrick

This pull request has now been integrated. Changeset: a52c4ede Author: Patrick Concannon <pconcannon@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/a52c4ede2f043b7d4a234c7d06f91871312e... Stats: 267 lines in 29 files changed: 1 ins; 125 del; 141 mod 8267110: Update java.util to use instanceof pattern variable Reviewed-by: lancea, naoto ------------- PR: https://git.openjdk.java.net/jdk/pull/4088