RFR: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details). ------------- Commit messages: - 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java Changes: https://git.openjdk.java.net/jdk/pull/2341/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2341&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260860 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2341.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2341/head:pull/2341 PR: https://git.openjdk.java.net/jdk/pull/2341
On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty <dcubed@openjdk.org> wrote:
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details).
@JimLaskey or @sundararajana - If either if you are on-line and can review this, I would appreciate it. Jim, you reviewed it the last time I ProblemListed it. Sundar, you took the test off the ProblemList before https://bugs.openjdk.java.net/browse/JDK-8247407 was fixed so we have failures again. ------------- PR: https://git.openjdk.java.net/jdk/pull/2341
On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty <dcubed@openjdk.org> wrote:
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details).
LGTM ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2341
On Mon, 1 Feb 2021 22:21:06 GMT, David Holmes <dholmes@openjdk.org> wrote:
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details).
LGTM
@dholmes-ora - Thanks for the fast review! ------------- PR: https://git.openjdk.java.net/jdk/pull/2341
On Mon, 1 Feb 2021 22:06:31 GMT, Daniel D. Daugherty <dcubed@openjdk.org> wrote:
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details).
This pull request has now been integrated. Changeset: 9880c4cd Author: Daniel D. Daugherty <dcubed@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/9880c4cd Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java Reviewed-by: dholmes ------------- PR: https://git.openjdk.java.net/jdk/pull/2341
On 01/02/2021 22:13, Daniel D.Daugherty wrote:
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details).
Something fishy here, Sundar ran the test 500 times on the 3 main platforms before integrating. I asked him to do this because of reliability issues with some of the jlink tests. linux-aarch64 was missed in that testing and we do seem to have an issue there at least. -Alan
On 2/2/21 2:46 AM, Alan Bateman wrote:
On 01/02/2021 22:13, Daniel D.Daugherty wrote:
A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the ProblemList. It was removed in error (see the bug for the details).
Something fishy here, Sundar ran the test 500 times on the 3 main platforms before integrating. I asked him to do this because of reliability issues with some of the jlink tests. linux-aarch64 was missed in that testing and we do seem to have an issue there at least.
-Alan
I've updated https://bugs.openjdk.java.net/browse/JDK-8247407 with a confidential comment and a link to bring up the recent test failures in the JDK17 CI. The linux-aarch64 failures were pretty constant, the linux-x64 and macOSX failures were intermittent. I think this was a reasonable ProblemListing given the failures that I observed yesterday. Dan
participants (4)
-
Alan Bateman
-
Daniel D.Daugherty
-
daniel.daugherty＠oracle.com
-
David Holmes