RFR: 8276042: Remove unused local variables in java.naming
8276042: Remove unused local variables in java.naming ------------- Commit messages: - [PATCH] Remove unused local variable in java.naming Changes: https://git.openjdk.java.net/jdk/pull/6091/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6091&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276042 Stats: 10 lines in 5 files changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/6091.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6091/head:pull/6091 PR: https://git.openjdk.java.net/jdk/pull/6091
On Sat, 23 Oct 2021 12:51:15 GMT, Andrey Turbanov <duke@openjdk.java.net> wrote:
8276042: Remove unused local variables in java.naming
Hi Andrey, Thanks for cleaning up the code. Changes look good to me, with one suggestion below. src/java.naming/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java line 514:
512: Object obj = cont.getResolvedObj(); 513: 514: if (obj instanceof PartialCompositeContext) {
Since we're changing this method, maybe `instanceof` pattern matching can be used here to remove casting below. ------------- Marked as reviewed by aefimov (Committer). PR: https://git.openjdk.java.net/jdk/pull/6091
On Wed, 27 Oct 2021 11:08:31 GMT, Aleksei Efimov <aefimov@openjdk.org> wrote:
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8276042: Remove unused local variables in java.naming use instanceof pattern
src/java.naming/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java line 514:
512: Object obj = cont.getResolvedObj(); 513: 514: if (obj instanceof PartialCompositeContext) {
Since we're changing this method, maybe `instanceof` pattern matching can be used here to remove casting below.
done ------------- PR: https://git.openjdk.java.net/jdk/pull/6091
8276042: Remove unused local variables in java.naming
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8276042: Remove unused local variables in java.naming use instanceof pattern ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/6091/files - new: https://git.openjdk.java.net/jdk/pull/6091/files/58bfec0d..f697d88c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6091&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6091&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6091.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6091/head:pull/6091 PR: https://git.openjdk.java.net/jdk/pull/6091
On Wed, 27 Oct 2021 15:42:32 GMT, Andrey Turbanov <duke@openjdk.java.net> wrote:
8276042: Remove unused local variables in java.naming
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8276042: Remove unused local variables in java.naming use instanceof pattern
Marked as reviewed by aefimov (Committer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6091
On Wed, 27 Oct 2021 15:42:32 GMT, Andrey Turbanov <duke@openjdk.java.net> wrote:
8276042: Remove unused local variables in java.naming
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8276042: Remove unused local variables in java.naming use instanceof pattern
Marked as reviewed by dfuchs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6091
On Wed, 27 Oct 2021 15:42:32 GMT, Andrey Turbanov <duke@openjdk.java.net> wrote:
8276042: Remove unused local variables in java.naming
Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
8276042: Remove unused local variables in java.naming use instanceof pattern
Looks good to me. ------------- Marked as reviewed by vtewari (Committer). PR: https://git.openjdk.java.net/jdk/pull/6091
On Sat, 23 Oct 2021 12:51:15 GMT, Andrey Turbanov <duke@openjdk.java.net> wrote:
8276042: Remove unused local variables in java.naming
This pull request has now been integrated. Changeset: 593401fe Author: Andrey Turbanov <turbanoff@gmail.com> Committer: Aleksei Efimov <aefimov@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/593401fe8b38bbb8d331a862818fe077af15... Stats: 12 lines in 5 files changed: 0 ins; 5 del; 7 mod 8276042: Remove unused local variables in java.naming Reviewed-by: aefimov, dfuchs, vtewari ------------- PR: https://git.openjdk.java.net/jdk/pull/6091
participants (4)
-
Aleksei Efimov
-
Andrey Turbanov
-
Daniel Fuchs
-
Vyom Tewari