RFR: 8261940: Fix references to IOException in BigDecimal javadoc
Noticed by some of Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page. ------------- Commit messages: - 8261940: Fix references to IOException in BigDecimal javadoc Changes: https://git.openjdk.java.net/jdk/pull/2623/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2623&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261940 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2623.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2623/head:pull/2623 PR: https://git.openjdk.java.net/jdk/pull/2623
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <darcy@openjdk.org> wrote:
Noticed by some of Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.
Looks okay but it might be simpler to just import java.io.IOException and avoid having two usages of the fully qualified name in the source file. ------------- Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2623
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <darcy@openjdk.org> wrote:
Noticed by some of Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.
Marked as reviewed by chegar (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2623
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <darcy@openjdk.org> wrote:
Noticed by some of Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.
Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2623
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <darcy@openjdk.org> wrote:
Noticed by some of Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.
I concur with @AlanBateman about importing `IOException`. ------------- Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2623
On Thu, 18 Feb 2021 16:52:19 GMT, Brian Burkhalter <bpb@openjdk.org> wrote:
Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
Respond to review feedback.
I concur with @AlanBateman about importing `IOException`.
Will integrate using the suggested import of java.io.IOException; thanks. ------------- PR: https://git.openjdk.java.net/jdk/pull/2623
Noticed by some of Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.
Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2623/files - new: https://git.openjdk.java.net/jdk/pull/2623/files/27ff1d78..e3a1659f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2623&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2623&range=00-01 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/2623.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2623/head:pull/2623 PR: https://git.openjdk.java.net/jdk/pull/2623
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <darcy@openjdk.org> wrote:
Noticed by some of Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.
This pull request has now been integrated. Changeset: c4664e64 Author: Joe Darcy <darcy@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/c4664e64 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8261940: Fix references to IOException in BigDecimal javadoc Reviewed-by: alanb, chegar, iris, bpb ------------- PR: https://git.openjdk.java.net/jdk/pull/2623
participants (5)
-
Alan Bateman
-
Brian Burkhalter
-
Chris Hegarty
-
Iris Clark
-
Joe Darcy