hg: jdk8/tl/jdk: 7168172: (fs) Files.isReadable slow on Windows
Changeset: bd91a601265c Author: khazra Date: 2012-08-24 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c 7168172: (fs) Files.isReadable slow on Windows Summary: Remove DACL checking for read access, also reviewed by Ulf.Zibis@CoSoCo.de, zhong.j.yu@gmail.com Reviewed-by: alanb ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java
Kurchi, thanks for listing me. BTW, my official openJDK ID is ulfzibis -Ulf Am 24.08.2012 20:49, schrieb kurchi.subhra.hazra@oracle.com:
Changeset: bd91a601265c Author: khazra Date: 2012-08-24 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c
7168172: (fs) Files.isReadable slow on Windows Summary: Remove DACL checking for read access, also reviewed by Ulf.Zibis@CoSoCo.de, zhong.j.yu@gmail.com Reviewed-by: alanb
! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java
It may not be enforced by tools, but I don't think you can be listed as a reviewer there unless you have the JDK 8 project reviewer attribute :- Alan does - http://openjdk.java.net/census#alanb but you don't - http://openjdk.java.net/census#ulfzibis Now maybe you should ask if you can be .. -phil. On 8/24/2012 12:20 PM, Ulf Zibis wrote:
Kurchi,
thanks for listing me.
BTW, my official openJDK ID is ulfzibis
-Ulf
Am 24.08.2012 20:49, schrieb kurchi.subhra.hazra@oracle.com:
Changeset: bd91a601265c Author: khazra Date: 2012-08-24 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c
7168172: (fs) Files.isReadable slow on Windows Summary: Remove DACL checking for read access, also reviewed by Ulf.Zibis@CoSoCo.de, zhong.j.yu@gmail.com Reviewed-by: alanb
! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java
Oops, thanks for your correction, Phil. Sorry, I wasn't aware about that difference. -Ulf Am 24.08.2012 21:40, schrieb Phil Race:
It may not be enforced by tools, but I don't think you can be listed as a reviewer there unless you have the JDK 8 project reviewer attribute :-
Alan does - http://openjdk.java.net/census#alanb
but you don't - http://openjdk.java.net/census#ulfzibis
Now maybe you should ask if you can be ..
-phil.
On 8/24/2012 12:20 PM, Ulf Zibis wrote:
Kurchi,
thanks for listing me.
BTW, my official openJDK ID is ulfzibis
-Ulf
Am 24.08.2012 20:49, schrieb kurchi.subhra.hazra@oracle.com:
Changeset: bd91a601265c Author: khazra Date: 2012-08-24 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c
7168172: (fs) Files.isReadable slow on Windows Summary: Remove DACL checking for read access, also reviewed by Ulf.Zibis@CoSoCo.de, zhong.j.yu@gmail.com Reviewed-by: alanb
! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java
Phil, On 25/08/2012 5:40 AM, Phil Race wrote:
It may not be enforced by tools, but I don't think you can be listed as a reviewer there unless you have the JDK 8 project reviewer attribute :-
That is not the case. While you may require a JDK 8 Reviewer (capital R) to approve a changset, additional authors (anyone with an openjdk username) can provide reviews and be listed on the Reviewed-by line. http://openjdk.java.net/guide/producingChangeset.html "A reviewed-by line is required. Reviewers must have the ability to deal with any adverse consequences of the change, and so must themselves be authors. They are therefore identified by their OpenJDK usernames rather than full e-mail addresses." This happens all the time. David
Alan does - http://openjdk.java.net/census#alanb
but you don't - http://openjdk.java.net/census#ulfzibis
Now maybe you should ask if you can be ..
-phil.
On 8/24/2012 12:20 PM, Ulf Zibis wrote:
Kurchi,
thanks for listing me.
BTW, my official openJDK ID is ulfzibis
-Ulf
Am 24.08.2012 20:49, schrieb kurchi.subhra.hazra@oracle.com:
Changeset: bd91a601265c Author: khazra Date: 2012-08-24 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c
7168172: (fs) Files.isReadable slow on Windows Summary: Remove DACL checking for read access, also reviewed by Ulf.Zibis@CoSoCo.de, zhong.j.yu@gmail.com Reviewed-by: alanb
! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java
participants (4)
-
David Holmes
-
kurchi.subhra.hazra@oracle.com
-
Phil Race
-
Ulf Zibis